Make cycle detection optional, to speed-up grounding and solving#38587
Closed
alalazo wants to merge 1 commit intospack:developfrom
Closed
Make cycle detection optional, to speed-up grounding and solving#38587alalazo wants to merge 1 commit intospack:developfrom
alalazo wants to merge 1 commit intospack:developfrom
Conversation
alalazo
force-pushed
the
solver/avoid_enforcing_absence_of_cycles_in_asp
branch
from
a6b28ce to
a848218
Compare
Member
Author
|
radiuss.a8482188a3911bb475cab08c990ff14621089fdf.csv
Table results
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #38447
A detailed profiling showed that computing paths is a very time consuming operation, even for our moderately small DAGs. Avoiding the computation of all possible paths speeds-up the solver greatly.
Currently we just assume that a solution has no cycle, and if we detect cycles after a fast solve, we fall back to recompute with the cycle detection rule enabled in ASP.