kokkos: enable +cuda_lambda by default for 4.0.00+#38565
Closed
brian-kelley wants to merge 3 commits intospack:developfrom
Closed
kokkos: enable +cuda_lambda by default for 4.0.00+#38565brian-kelley wants to merge 3 commits intospack:developfrom
brian-kelley wants to merge 3 commits intospack:developfrom
Conversation
brian-kelley
changed the title
This was referenced Jun 26, 2023
eugeneswalker
approved these changes
Jun 27, 2023
Contributor
Author
|
@eugeneswalker It turns out that this does not actually work the way I thought - it's not currently possible to have version-dependent defaults for variants. This feature was also requested by someone else in #38302 though, and it's actively being worked on. So this is just going to be a draft PR until that feature reaches the |
masterleinad
reviewed
Apr 8, 2024
Contributor
masterleinad
left a comment
masterleinad
left a comment
There was a problem hiding this comment.
@brian-kelley Can you try again after #40326 and #40998 have been merged?
Contributor
Author
|
@masterleinad Yes, the default behavior works now (lambda off by default pre-4.0, but on for later versions). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kokkos_ENABLE_CUDA_LAMBDA(the CMake option) has been ON by default since version 4.0.00, so this makes the corresponding variantcuda_lambdahave the same default behavior.Tested by installing the following recipes: