Package.is_extension now uses Spec.concrete#3853
Closed
scheibelp wants to merge 1 commit intospack:developfrom
Closed
Package.is_extension now uses Spec.concrete#3853scheibelp wants to merge 1 commit intospack:developfrom
scheibelp wants to merge 1 commit intospack:developfrom
Conversation
Originally Package.is_extension was using Spec._concrete. This replaces the direct access to the cached variable with a call to the property function (since in some cases, e.g. after a copy, _concrete is not set properly).
Member
Member
|
I think only in exceptional cases we should merge core PRs without regression tests. Otherwise, given tge complexity of Spack's core, a fix for one issues would be breaking a fix for another and we would go in circles. |
Member
Author
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Aug 20, 2020
becker33
pushed a commit
that referenced
this pull request
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses an issue observed in #3227 where extendee_spec on a package was present because the package was not considered concrete (according to the
._concreteproperty).Originally Package.is_extension was using Spec._concrete. This replaces the direct access to the cached variable with a call to the property function (since in some cases, e.g. after a copy, _concrete is not set properly).