Add --fail-fast option for generating build caches#38496
Merged
alalazo merged 6 commits intospack:developfrom Aug 23, 2023
Merged
Add --fail-fast option for generating build caches#38496alalazo merged 6 commits intospack:developfrom
alalazo merged 6 commits intospack:developfrom
Conversation
Contributor
Author
|
@haampie Gentle reminder for this PR ... we need this for our macOS CI systems. Thanks very much! |
Contributor
Author
|
@haampie @scheibelp Another gentle reminder for this PR (now a few months old) ... I updated the code this morning and the unit tests pass except for an odd codecov/patch failure. Thanks! |
haampie
force-pushed
the
feature/buildcache_fail_fast
branch
from
6b2f42e to
ebadf6a
Compare
haampie
force-pushed
the
feature/buildcache_fail_fast
branch
from
bb78e6c to
1005ab5
Compare
haampie
approved these changes
Aug 18, 2023
Member
|
I pushed a commit that makes an exception for some exceptions and actually reraises an exception s.t. the exit code is correct. |
Contributor
Author
Thanks @haampie your changes look good! |
alalazo
approved these changes
Aug 23, 2023
Contributor
Author
mpokorny
pushed a commit
to mpokorny/spack
that referenced
this pull request
Sep 18, 2023
Co-authored-by: Harmen Stoppels <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
--fail-fastoption for generating build caches tolib/spack/spack/cmd/buildcache.py. This implementation follows a suggestion made by @haampie in #35601 (comments #35601 (comment) and #35601 (comment)).The default behavior is the same as for
spack install, which meansspack buildcache createwill make best efforts and ignore build cache creation failures (but report them at the end).