matplotlib and basemap require setuptools to run properly together#3835
matplotlib and basemap require setuptools to run properly together#3835adamjstewart merged 3 commits intodevelopfrom
Conversation
lee218llnl
force-pushed
the
bugfix/basemap-matplotlib
branch
from
445f622 to
03cef6e
Compare
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Oh wow, this is way cleaner!
|
Can you add a short comment above the setuptools dependencies explaining why they are needed at runtime? |
|
This addresses #3813 |
citibeth
left a comment
citibeth
left a comment
There was a problem hiding this comment.
Great solution. Please add comments explaining the otherwise-unusual choice of having py-setuptools as a run dependency.
| version('1.0.7', '48c0557ced9e2c6e440b28b3caff2de8') | ||
|
|
||
| depends_on('py-setuptools', type='build') | ||
| depends_on('py-setuptools', type=('build', 'run')) |
There was a problem hiding this comment.
Please add a comment for this line that (1) gives a brief explanation and (2) links to #3813
|
|
||
| # ------ Required dependencies | ||
| depends_on('py-setuptools', type='build') | ||
| depends_on('py-setuptools', type=('build', 'run')) |
There was a problem hiding this comment.
Same comment here as on py-basemap
lee218llnl
force-pushed
the
bugfix/basemap-matplotlib
branch
from
03cef6e to
46344ff
Compare
|
@citibeth Can you approve? |
|
@citibeth Do the comments in the package that address the "run" dependence look OK to you? |
|
Looks like there's a conflict. Can you rebase/merge? |
|
@adamjstewart not sure why it considered that a conflict as the "change" in the develop branch was blank. |
|
|
||
| version('1.0.7', '48c0557ced9e2c6e440b28b3caff2de8') | ||
|
|
||
|
|
There was a problem hiding this comment.
This extra line will cause the flake8 test to fail.
|
@adamjstewart looks like we passed through travis. I think this is ready to be merged unless there's anything else you would like me to address. |
…pack#3835) * matplotlib and basemap require setuptools to run properly together * flake 8 fix
…pack#3835) * matplotlib and basemap require setuptools to run properly together * flake 8 fix
…pack#3835) * matplotlib and basemap require setuptools to run properly together * flake 8 fix
…3835) * matplotlib and basemap require setuptools to run properly together * flake 8 fix
3 participants
Fixes #3813.
matplotlib and basemap require setuptools at runtime in order to allow the mpl_toolkits package to be considered a namespace package and thus look in both matplotlib and basemap's mpl_toolkits directory. This also removes the need for the patch in #1964.