Skip to content

NetCDF-C: default to CMake#38264

Closed
adamjstewart wants to merge 2 commits intospack:developfrom
adamjstewart:packages/netcdf-c
Closed

NetCDF-C: default to CMake#38264
adamjstewart wants to merge 2 commits intospack:developfrom
adamjstewart:packages/netcdf-c

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

I tried building netcdf-c on macOS and got the following error:

configure: error: Error: OSX requires libxml2 => --disable-dap4.

Building with CMake went fine. I'm sure it's possible to fix this error, but is there any reason we don't default to CMake on all systems?

@spackbot-app spackbot-app bot requested review from WardF and skosukhin June 8, 2023 18:27
@adamjstewart
Copy link
Copy Markdown
Member Author

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jun 9, 2023

I've started that pipeline for you!

@skosukhin
Copy link
Copy Markdown
Member

I'm not sure about this. I will give details on Monday.

@skosukhin
Copy link
Copy Markdown
Member

I do not think that the netcdf-c's CMakeBuilder is mature enough to cover all side-effects and edge cases (see #36485 (comment)), and cannot tell yet when I have time to work on that. Currently, I would use it only in cases when AutotoolsBuilder doesn't work.

The reported issue should be fixed with #38324.

@adamjstewart
Copy link
Copy Markdown
Member Author

Makes sense, thanks for the fix to the Autotools build system!

@adamjstewart adamjstewart deleted the packages/netcdf-c branch June 14, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants