Package requirements: support cflags (attempt 2)#37584
Merged
alalazo merged 5 commits intospack:developfrom May 11, 2023
Merged
Package requirements: support cflags (attempt 2)#37584alalazo merged 5 commits intospack:developfrom
alalazo merged 5 commits intospack:developfrom
Conversation
This reverts commit 0db54ba.
… the adjustments to asp.py are for assembling the spec after the solve
…r reuse of asp.impose(); imposed_constraint is what we actually want to impose
spackbot-app
bot
added
core
alalazo
approved these changes
May 11, 2023
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Aug 23, 2023
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Aug 24, 2023
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Oct 16, 2023
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Oct 17, 2023
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Oct 18, 2023
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37163
Fixes #34241
Temporary alternative to #37180
Adds choice rules for compiler flags specifically, allowing solver to set compiler flags introduced by requirements.