Skip to content

Code checking : flake8 and code coverage#375

Merged
tgamblin merged 9 commits intospack:developfrom
epfl-scitas:qa/coding_standard
May 10, 2016
Merged

Code checking : flake8 and code coverage#375
tgamblin merged 9 commits intospack:developfrom
epfl-scitas:qa/coding_standard

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Jan 19, 2016

Modifications :

  • added flake8 and pep8 checks to Travis
  • added coverage results to unit tests
  • added a style file for yapf which is conformant with the checks above

Notes :

  • I didn't add pylint as it requires more set-up. According to the documentation it can be run only on packages or modules, not single files.

Follows from #337

IanLee1521
IanLee1521 reviewed Feb 5, 2016
View reviewed changes
.travis.yml Outdated
# Install coveralls to obtain code coverage
install:
- "pip install coveralls"
- "pip install pep8"
Copy link
Copy Markdown
Member

@IanLee1521 IanLee1521 Feb 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can/should come out. The install of flake8 will pull in pep8 as a dependency. Also, this will help as I am getting ready to rename pep8 -> pycodestyle.

Copy link
Copy Markdown
Member Author

@alalazo alalazo Feb 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IanLee1521 Ok, will remove any explicit reference to pep8

@alalazo alalazo changed the title Code checking : pep8, flake8 and code coverage Code checking : flake8 and code coverage Feb 5, 2016
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Feb 5, 2016

@IanLee1521 done

@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Apr 7, 2016

@tgamblin What about adding a 'coverage' badge to the main page? 😄

@tgamblin
Copy link
Copy Markdown
Member

tgamblin commented Apr 7, 2016

@alalazo: yes please

@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Apr 15, 2016

@tgamblin The coverage badge should be there!

@alalazo alalazo mentioned this pull request May 9, 2016
Merged
@tgamblin tgamblin merged commit c005b5f into spack:develop May 10, 2016
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented May 10, 2016

@tgamblin Just for the record, the line length here is set at 120 chars, as you guessed yesterday... feel free to change any setting you want...

@tgamblin
Copy link
Copy Markdown
Member

tgamblin commented May 10, 2016

You must've missed it 😄

@alalazo alalazo deleted the qa/coding_standard branch May 10, 2016 08:56
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented May 10, 2016 •
edited
Loading

@tgamblin Do you want to change also flake8.ini? That will make test fail if we ever pass the 80 chars limit (right now it is still at 120)

@tgamblin
Copy link
Copy Markdown
Member

tgamblin commented May 10, 2016

oh right -- I missed that. Fixed! Back to 79 chars per PEP8.

@adamjstewart adamjstewart mentioned this pull request May 10, 2016
Merged
climbfuji added a commit to climbfuji/spack that referenced this pull request Dec 4, 2023
@climbfuji
Merge pull request spack#375 from climbfuji/bugfix/curl_intel_from_sp…
55e6388 
…ack_dev

From spack-dev: Fix curl install using Intel compilers (spack#41380)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alalazo @tgamblin @IanLee1521