Skip to content

geant4-data: add v11.0.1 -> v11.1.1#37383

Closed
greenc-FNAL wants to merge 1 commit intospack:developfrom
greenc-FNAL:bugfix/geant4-data-missing-versions
Closed

geant4-data: add v11.0.1 -> v11.1.1#37383
greenc-FNAL wants to merge 1 commit intospack:developfrom
greenc-FNAL:bugfix/geant4-data-missing-versions

Conversation

@greenc-FNAL
Copy link
Copy Markdown
Member

No description provided.

@drbenmorgan
Copy link
Copy Markdown
Member

Suggest we get this in after #37382, as it should not depend on #37380, but is needed for #37381 (I think...)

@greenc-FNAL
Copy link
Copy Markdown
Member Author

greenc-FNAL commented May 2, 2023

Suggest we get this in after #37382, as it should not depend on #37380, but is needed for #37381 (I think...)

It is needed by #37381. If #37382 precedes it, then an attempt to actually use geant4 10.7.4 will result in a failure due to the lack of a suitable geant4-data setup.

#37382 should probably follow #37380, #37381 and #37383 just for this reason.

Fun, no?

@drbenmorgan
Copy link
Copy Markdown
Member

My point, as in #37382, is that it's possible to cherry-pick the commits adding the 10.7.4 version and missing data versions (modulo conflicts, adding back in _vers) and get these in before the revision to how these are connected up in #37380 and #37381. This reduces the train of PRs, and adding 10.7.4 on its own is a good update. O.k., still needs the list of versions in Geant4's package.py, but then there'll a single commit replacing this with the functionality added in #37380.

Otherwise this should be marked as Draft so the order in which things should be rebased/reviewed/merged is clear.

@drbenmorgan drbenmorgan marked this pull request as draft May 2, 2023 16:14
@alecbcs alecbcs changed the title [geant4-data] Add missing versions geant4-data: add v11.0.1 -> v11.1.1 May 24, 2024
@alalazo
Copy link
Copy Markdown
Member

alalazo commented Jun 15, 2025

Closing, since there has been no activity in a while. Feel free to reopen at / migrate to https://github.com/spack/spack-packages if you want to continue work on this.

@alalazo alalazo closed this Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants