Closes #37380.

@greenc-FNAL, I guess this should be marked as Draft until #37380 is merged? It seems to have similar/same commits.

Will also need #37383 to pass audit tests.

Can we just make a new directive like this for all packages? Dozens of packages need this feature, not just this one.

Can we just make a new directive like this for all packages? Dozens of packages need this feature, not just this one.

Of course. I'm not sure of the best way to make the directive simple to use and flexible enough for the general case, though. Something like this, maybe? Unfortunately, I have no idea what an implementation of _merge() would look like.

def _merge(dep_spec, spec_bit):
  """Here, a miracle occurs."""
  pass

@directive(("dependencies"))
def depends_on_matching_version(spec):
    """Package-specific directive to depend on the corresponding version of a given spec"""

    def _execute_depends_on_matching_version(pkg):
        dep_spec = Spec(spec)
        for vers in pkg.versions.keys():
            this_dep_spec = _merge(dep_spec, f"@{vers}")
            pkg_depends_on(pkg, this_dep_spec, when=f"@{vers}", type="run")

    return _execute_depends_on_matching_version

There was an initial attempt in #14002 but that PR was abandoned. Basically the only thing I would change is to wrap this into the existing depends_on directive instead of creating a new directive. We'll need a flag to control the number of digits since some packages require the same X.Y.* while others require exactly X.Y.Z.

I'm fine with wrapping this into the OG depends_on(), but I'm still not seeing how to implement _merge(): depends_on() accepts spec which may include variants, flags, or even (not particularly sensible, but still) a version. I need a way to merge an anonymous spec (just the version) with the given named spec in an unambiguous way, and a first sweep of spec.py wasn't enough to illuminate one for me. Any pointers gratefully accepted.

We'll need a flag to control the number of digits since some packages require the same X.Y.* while others require exactly X.Y.Z.

I'm fine with the pkg_to_dep_version function parameter from #14002 since one can easily send Version or lambda ver: ver.up_to(2).

@adamjstewart I think I have an implementation: testing now.

See #37418.

This pull request has been automatically marked as stale because it has not had
any activity in the last 6 months. It will be closed if there is no further activity.
Thank you for your contributions!

This pull request was closed because it had no activity for 30 days after being marked stale.