Disable module file generation by default#37258
Merged
alalazo merged 5 commits intospack:developfrom May 2, 2023
Merged
Conversation
a) It's used by site administrators, so it's niche b) If it's used by site administrators, they likely need to modify the config anyhow, so the default config only serves as an example to get started c) it's too arbitrary to enable tcl, but disable lmod
spackbot-app
bot
added
core
haampie
reviewed
Apr 28, 2023
Member
|
Maybe this is too much, but can the warning be narrowed to tcl? Also useful to say how to enable it |
Member
Author
I'll check that. There's potentially another case where this can emit spurious warnings, i.e. somebody that for any unknown reason is deliberately not using the "default" module set, but others. I didn't consider that case because I don't see where it could make sense to do that, since the module set name is never exposed anywhere in the generated modules. |
Member
Author
|
Latest version: |
haampie
approved these changes
May 1, 2023
Member
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
Member
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
joequant
pushed a commit
to hkphysics/spack
that referenced
this pull request
May 2, 2023
* Disable module generation by default (spack#35564) a) It's used by site administrators, so it's niche b) If it's used by site administrators, they likely need to modify the config anyhow, so the default config only serves as an example to get started c) it's too arbitrary to enable tcl, but disable lmod * Remove leftover from old module file schema * Warn if module file config is detected and generation is disabled --------- Co-authored-by: Harmen Stoppels <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows a poll done in Slack over a month ago.
Modifications:
This is an example of a custom
modules.yamltriggering a warning + an example of "normal" working mode: