Add macOS ML CI stacks#36586
Conversation
|
Curl failed in But succeeded in From the failed build: Notice the hash is the same, and both of those jobs ran on the same runner |
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
da27d02 to
8291fab
Compare
|
The failures here look like mostly, if not entirely, relocation issues: All of these packages I am able to build, using the same spack.yaml, same git commit, building locally on the same runner machine where they failed in the pipeline, if I (1) use no binaries from cache and (2) use no padding. |
|
^ @haampie |
|
Here is the problem: The problem is, the relocated I don't yet know why... looking into it... Looking at the debug logs showing relocation of Focusing on the first part of This doesn't look right, because the second path here does not match where we are installing perl, as there is no |
|
Looking here: spack/lib/spack/spack/relocate.py Lines 232 to 235 in a9db562 It first sets the relocation mapping correctly: But then immediately overwrites the prior, correct relocation path, with an incorrect one: |
|
Thanks for digging into that @eugeneswalker. Not sure why the logic is custom for macho files. |
|
macho sounds way better than Mach-O 💪 |
0dad414 to
f2caede
Compare
|
@spackbot run pipeline |
|
I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now. One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a Please check the gitlab commit status message to see if more information is available. DetailsUnexpected response from gitlab: {'message': '404 Commit Not Found'} |
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
|
A number of current CI errors are due to the fact I forgot to install |
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
e66794e to
c68e42e
Compare
|
All CI finally passing here. I have one last tweak to make before we merge though, so let us defer merge until then. Should be ready very soon. |
share/spack/gitlab/cloud_pipelines/configs/darwin/aarch64/compilers.yaml
Outdated
Show resolved
Hide resolved
share/spack/gitlab/cloud_pipelines/stacks/ml-darwin-aarch64-mps/spack.yaml
Show resolved
Hide resolved
|
@haampie we're likely going to merge this soon, but if you can investigate the remaining code signing/relocation issues in a follow-up PR, that would be much appreciated. Let me know if you want us to open an issue to help track this. |
share/spack/gitlab/cloud_pipelines/configs/darwin/aarch64/compilers.yaml
Outdated
Show resolved
Hide resolved
|
@spackbot run pipeline because one of the |
|
I've started that pipeline for you! |
See #31551