Conversation
|
Hi @johnwparent! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("johnwparent")If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame libxml2Thank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
| depends_on("[email protected]:", type="build", when="build_system=autotools") | ||
| # conditional on non Windows, but rather than specify for each platform | ||
| # specify for non Windows builder, which has equivalent effect | ||
| depends_on("iconv", when="build_system=autotools") |
There was a problem hiding this comment.
(no change needed) I'll be talking internally about how to add some syntactic sugar like do_this_everywhere_except("windows") and hopefully this can be streamlined
|
@scheibelp all outstanding changes have been addressed. |
2 participants
Introduce support for libxml2's NMake build system. This allows Spack to build libxml2 on Windows. This is a paraview dependency and was somehow dropped from the PRs created from the initial paraview dep PR.