Skip to content

openblas: use "all" target since it's marked sequential#35905

Merged
haampie merged 2 commits intospack:developfrom
haampie:fix/openblas-again
Apr 3, 2023
Merged

openblas: use "all" target since it's marked sequential#35905
haampie merged 2 commits intospack:developfrom
haampie:fix/openblas-again

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Mar 7, 2023

openblas likes to concurrently write to the same archive from different
targets, and solves that through .NOTPARALLEL: all

We run make x y z which is not affected by NOTPARALLEL, running into
races.

This adds back the tests target unconditionally, but I don't see a better
way other than running make x && make y && make z.

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Mar 7, 2023

Hi @haampie! I noticed that the following package(s) don't yet have maintainers:

  • openblas

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("haampie")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame openblas

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@haampie
Copy link
Copy Markdown
Member Author

haampie commented Mar 8, 2023

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Mar 8, 2023

I've started that pipeline for you!

@haampie haampie force-pushed the fix/openblas-again branch from d949520 to 37ca263 Compare March 14, 2023 12:43
openblas likes to concurrently writes to the same archive from different
targets, and solves that through .NOTPARALLEL: all

We run `make x y z` which is not affected by `NOTPARALLEL`, running into
races.
@alalazo alalazo force-pushed the fix/openblas-again branch from 37ca263 to e668acf Compare March 17, 2023 10:29
@haampie haampie merged commit 93cad90 into spack:develop Apr 3, 2023
@haampie haampie deleted the fix/openblas-again branch April 3, 2023 09:45
eugeneswalker pushed a commit to eugeneswalker/spack that referenced this pull request Jul 31, 2023
openblas likes to concurrently writes to the same archive from different
targets, and solves that through .NOTPARALLEL: all

We run `make x y z` which is not affected by `NOTPARALLEL`, running into
races.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants