Skip to content

new py-thop package#35889

Merged
adamjstewart merged 3 commits intospack:developfrom
Sangu-Mbekelu:add_py-thop
Mar 8, 2023
Merged

new py-thop package#35889
adamjstewart merged 3 commits intospack:developfrom
Sangu-Mbekelu:add_py-thop

Conversation

@Sangu-Mbekelu
Copy link
Copy Markdown
Contributor

No description provided.

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Mar 6, 2023

Hi @Sangu-Mbekelu! I noticed that the following package(s) don't yet have maintainers:

  • py-thop

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("Sangu-Mbekelu")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-thop

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@Sangu-Mbekelu
Copy link
Copy Markdown
Contributor Author

@spackbot fix style

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Mar 6, 2023

Let me see if I can fix that for you!

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Mar 6, 2023

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/py-thop/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/py-thop/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
Success: no issues found in 576 source files
  mypy checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the sha256.

@tldahlgren tldahlgren requested a review from adamjstewart March 6, 2023 17:11
@tldahlgren tldahlgren self-assigned this Mar 6, 2023
@adamjstewart adamjstewart self-assigned this Mar 6, 2023
modified the url and dependencies
@adamjstewart adamjstewart merged commit 2777ca8 into spack:develop Mar 8, 2023
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
* "new py-thop package"

* [@spackbot] updating style on behalf of Sangu-Mbekelu

* Update package.py

modified the url and dependencies

---------

Co-authored-by: Sangu Mbekelu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants