Skip to content

hpctoolkit: add version 2023.03.01, add python variant#35662

Merged
alalazo merged 2 commits intospack:developfrom
mwkrentel:krentel/toolkit-2023-02
Mar 1, 2023
Merged

hpctoolkit: add version 2023.03.01, add python variant#35662
alalazo merged 2 commits intospack:developfrom
mwkrentel:krentel/toolkit-2023-02

Conversation

@mwkrentel
Copy link
Copy Markdown
Member

@mwkrentel mwkrentel commented Feb 23, 2023

  1. add version 2023.02.20
  2. add variant 'python' that supports unwinding python source
  3. clean up some things with the cray variant
  4. require the latest libmonitor
  5. fix sha256 checksum for url patch
  6. delete rocm 5.3 from older versions

@mwkrentel mwkrentel mentioned this pull request Feb 23, 2023
Merged
@mwkrentel
Copy link
Copy Markdown
Member Author

mwkrentel commented Feb 23, 2023

@spackbot fix style

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Feb 23, 2023

Let me see if I can fix that for you!

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Feb 23, 2023

I was able to run spack style --fix for you!

spack style --fix 
==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/hpctoolkit/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/hpctoolkit/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
Success: no issues found in 576 source files
  mypy checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@mwkrentel
Copy link
Copy Markdown
Member Author

mwkrentel commented Feb 25, 2023

There is a mistake in how hpctoolkit tests for the rocm version.
That's why it fails for recent rocm.

We'll fix this in hpctoolkit and push up a new release in a few days.

@mwkrentel mwkrentel mentioned this pull request Feb 27, 2023
Merged
@mwkrentel
hpctoolkit: add version 2023.03.01, add python variant
55b4b34 
 1. add version 2023.03.01
 2. add variant 'python' that supports unwinding python source
 3. clean up some things with the cray variant
 4. require the latest libmonitor
 5. fix sha256 checksum for url patch
 6. delete rocm 5.3 from older versions
@mwkrentel mwkrentel force-pushed the krentel/toolkit-2023-02 branch from 64697bb to 55b4b34 Compare March 1, 2023 04:33
@spackbot-app spackbot-app bot added the patch label Mar 1, 2023
@mwkrentel mwkrentel changed the title hpctoolkit: add version 2023.02.20, add python variant hpctoolkit: add version 2023.03.01, add python variant Mar 1, 2023
@mwkrentel
Copy link
Copy Markdown
Member Author

mwkrentel commented Mar 1, 2023

@spackbot style --fix

@mwkrentel
Copy link
Copy Markdown
Member Author

mwkrentel commented Mar 1, 2023

@spackbot fix style

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Mar 1, 2023

Let me see if I can fix that for you!

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Mar 1, 2023

I was able to run spack style --fix for you!

spack style --fix 
==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/hpctoolkit/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/hpctoolkit/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
Success: no issues found in 576 source files
  mypy checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

alalazo
alalazo approved these changes Mar 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left two minor comments. If this seems good to go I'll merge it.

var/spack/repos/builtin/packages/hpctoolkit/package.py
Comment on lines +52 to +54
"cray",
default=False,
description="Build hpcprof-mpi for Cray systems (may require --dirty).",
Copy link
Copy Markdown
Member

@alalazo alalazo Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: using sticky=True prevents clingo from accidentaly changing this variant (and require users to change it explicitly if need be). If that's useful we can add that in another PR.

Copy link
Copy Markdown
Member Author

@mwkrentel mwkrentel Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand.

Copy link
Copy Markdown
Member

@alalazo alalazo Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://spack.readthedocs.io/en/latest/packaging_guide.html#sticky-variants

Copy link
Copy Markdown
Member Author

@mwkrentel mwkrentel Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'll have to think about this for a while.
I don't feel that I understand all the implications of using sticky.
But it's good to know, a useful tool in the toolbox. Thanks!

@alalazo alalazo self-assigned this Mar 1, 2023
@alalazo alalazo merged commit 99fb4c4 into spack:develop Mar 1, 2023
koysean pushed a commit to koysean/spack that referenced this pull request Mar 7, 2023
@mwkrentel @koysean
hpctoolkit: add version 2023.03.01, add python variant (spack#35662)
d4714e6 
 1. add version 2023.03.01
 2. add variant 'python' that supports unwinding python source
 3. clean up some things with the cray variant
 4. require the latest libmonitor
 5. fix sha256 checksum for url patch
 6. delete rocm 5.3 from older versions
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
@mwkrentel @jmcarcell
hpctoolkit: add version 2023.03.01, add python variant (spack#35662)
7ec725a 
 1. add version 2023.03.01
 2. add variant 'python' that supports unwinding python source
 3. clean up some things with the cray variant
 4. require the latest libmonitor
 5. fix sha256 checksum for url patch
 6. delete rocm 5.3 from older versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalazo alalazo alalazo approved these changes

Assignees

@alalazo alalazo

Labels

conflicts dependencies new-variant new-version patch update-package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mwkrentel @alalazo