Merged
Conversation
tldahlgren
reviewed
Feb 23, 2023
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Confirmed the sha256.
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
The base class adds python as a build/run dep, but the package adds it as a build/link dep. Does the package actually link to python's libs/headers? If not I would remove the python dep since it's already added by the base class and Spack only supports 3.7+ anyway
Contributor
Author
|
@adamjstewart , would you please ping the original author of this package? |
Member
|
I'm pretty sure I'm the one who wrote it. I just checked and it doesn't link to python, so you can simply remove the dep and use the one inherited from the base class. |
adamjstewart
approved these changes
Mar 2, 2023
jmcarcell
pushed a commit
to key4hep/spack
that referenced
this pull request
Apr 13, 2023
* scons: add a new version * scons: address @adamjstewart review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help #35649