daos: add a new package by hyoklee · Pull Request #35649 · spack/spack

hyoklee · 2023-02-23T17:19:17Z

Depends on #35520

See https://github.com/daos-stack/daos for details.

See also #4927

var/spack/repos/builtin/packages/daos/package.py

alalazo

PKG-DIRECTIVES: 8 issues found
1. daos: unknown package 'isa-l' in 'depends_on' directive
     in /home/runner/work/spack/spack/var/spack/repos/builtin/packages/daos/package.py
2. daos: unknown package 'isa-l_crypto' in 'depends_on' directive
     in /home/runner/work/spack/spack/var/spack/repos/builtin/packages/daos/package.py
3. daos: unknown package 'spdk' in 'depends_on' directive
     in /home/runner/work/spack/spack/var/spack/repos/builtin/packages/daos/package.py
4. daos: dependency on [email protected]: cannot be satisfied by known versions of scons
    happening in /home/runner/work/spack/spack/var/spack/repos/builtin/packages/daos/package.py
    known versions of scons are 4.3.0, 4.2.0, 4.1.0.post1, 4.0.1, 4.0.0, 3.1.2, 3.1.1, 3.1.0, 3.0.5, 3.0.4, 3.0.1
5. daos: dependency on [email protected]: cannot be satisfied by known versions of dpdk
    happening in /home/runner/work/spack/spack/var/spack/repos/builtin/packages/daos/package.py
    known versions of dpdk are 20.02, [19](https://github.com/spack/spack/actions/runs/4294446033/jobs/7483488342#step:6:20).11, 19.08, 19.05, 19.02
6. daos: dependency on isa-l cannot be satisfied by known versions of isa-l
    happening in /home/runner/work/spack/spack/var/spack/repos/builtin/packages/daos/package.py
7. daos: dependency on isa-l_crypto cannot be satisfied by known versions of isa-l_crypto
    happening in /home/runner/work/spack/spack/var/spack/repos/builtin/packages/daos/package.py
8. daos: dependency on spdk@[23](https://github.com/spack/spack/actions/runs/4294446033/jobs/7483488342#step:6:24).01:+rdma+shared cannot be satisfied by known versions of spdk
    happening in /home/runner/work/spack/spack/var/spack/repos/builtin/packages/daos/package.py

hyoklee · 2023-03-01T14:14:27Z

@alalazo I made separate PRs for dependencies. If you merge them, there will be no dependency check error.

var/spack/repos/builtin/packages/daos/package.py

hyoklee · 2023-03-16T16:59:36Z

@alalazo @soumagne @tldahlgren would you please merge this?

soumagne · 2023-03-16T17:10:01Z

this one looks good to me now

tldahlgren · 2023-03-16T17:10:49Z

Still getting audit issue below so noted dependency.

PKG-DIRECTIVES: 2 issues found
1. daos: unknown package 'spdk' in 'depends_on' directive
     in /home/runner/work/spack/spack/var/spack/repos/builtin/packages/daos/package.py
2. daos: dependency on [email protected]:+dpdk+rdma+shared cannot be satisfied by known versions of spdk
    happening in /home/runner/work/spack/spack/var/spack/repos/builtin/packages/daos/package.py

tldahlgren

Confirmed the branch and tag. Just waiting on the dependency so this can be updated.

alalazo · 2023-03-17T09:42:03Z

would you please merge this?

CI must pass before we merge, this is still waiting for dependencies to be added, and CI to re-run. In general, if you have related changes, I'd advise to submit them as a single PR instead of multiple PRs with dependencies among themselves.

hyoklee · 2023-04-27T14:02:34Z

@spackbot run pipeline

spackbot-app · 2023-04-27T14:02:43Z

I've started that pipeline for you!

hyoklee · 2023-04-27T16:14:40Z

@alalazo and @tldahlgren , all checks passed. Would you please merge this PR?

var/spack/repos/builtin/packages/daos/package.py

alalazo

I left a few comments, let me know if anything is unclear. Thanks!

var/spack/repos/builtin/packages/daos/package.py

hyoklee · 2023-05-11T15:56:47Z

@alalazo , would you please merge this PR?

hyoklee · 2023-05-15T15:56:41Z

@tldahlgren , would you please merge this PR?

kwryankrattiger

LGTM

daos: add a new package

1fae1d1

spackbot-app bot added dependencies new-package new-variant new-version patch labels Feb 23, 2023

This was referenced Feb 23, 2023

isa-l: add a new package #35650

Merged

isa-l_crypto: add a new package #35651

Merged

fix: replace _ with - for isa-l-crypto dependency

815423f

This was referenced Feb 23, 2023

scons: add a new version #35652

Merged

hdf5-vol-daos: add a new package #35653

Merged

soumagne reviewed Feb 23, 2023

View reviewed changes

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

tldahlgren assigned soumagne Feb 23, 2023

tldahlgren self-requested a review February 23, 2023 20:44

tldahlgren self-assigned this Feb 23, 2023

hyoklee added 2 commits February 24, 2023 11:39

fix: remove daos < 2.2.0 per @soumagne reivew

c89cf69

fix: remove daos < 2.2.0 patches

5e579ca

soumagne reviewed Feb 28, 2023

View reviewed changes

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

soumagne reviewed Feb 28, 2023

View reviewed changes

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

soumagne reviewed Feb 28, 2023

View reviewed changes

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

daos: address @soumagne reviews

63d2300

alalazo requested changes Mar 1, 2023

View reviewed changes

soumagne reviewed Mar 1, 2023

View reviewed changes

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

koysean reviewed Mar 1, 2023

View reviewed changes

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

daos: address @soumagne and @koysean reviews

bc07933

soumagne reviewed Mar 3, 2023

View reviewed changes

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

soumagne reviewed Mar 3, 2023

View reviewed changes

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

daos: address @soumagne review on dpdk

89aa3b5

koysean reviewed Mar 7, 2023

View reviewed changes

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

hyoklee added 3 commits March 7, 2023 13:39

daos: fix audit failure

562ebf7

daos: fix audit failure

a8cfae8

daos: fix typo in @koysean patch

0213744

soumagne previously approved these changes Mar 16, 2023

View reviewed changes

tldahlgren previously approved these changes Mar 16, 2023

View reviewed changes

fix(daos): resolve spdk version

836f55d

hyoklee dismissed stale reviews from tldahlgren and soumagne via 836f55d April 27, 2023 14:10

hyoklee requested a review from alalazo April 27, 2023 16:14

soumagne reviewed Apr 27, 2023

View reviewed changes

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

fix(daos): address @soumagne review by removing mpich

36920b4

soumagne approved these changes Apr 28, 2023

View reviewed changes

alalazo requested changes Apr 28, 2023

View reviewed changes

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

soumagne suggested changes Apr 28, 2023

View reviewed changes

var/spack/repos/builtin/packages/daos/package.py Outdated Show resolved Hide resolved

hyoklee added 2 commits April 28, 2023 10:48

fix(daos): remove develop and py from boost per @alalazo review

068f24a

fix(daos): address @alalazo review

14c1364

Merge branch 'develop' into hyoklee-daos

652e6d5

hyoklee requested a review from alalazo May 23, 2023 13:11

kwryankrattiger approved these changes May 23, 2023

View reviewed changes

alalazo approved these changes May 23, 2023

View reviewed changes

alalazo merged commit 55d7fec into spack:develop May 23, 2023

Conversation

hyoklee commented Feb 23, 2023 • edited by tldahlgren Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alalazo left a comment

Choose a reason for hiding this comment

Uh oh!

hyoklee commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hyoklee commented Mar 16, 2023

Uh oh!

soumagne commented Mar 16, 2023

Uh oh!

tldahlgren commented Mar 16, 2023

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

alalazo commented Mar 17, 2023

Uh oh!

hyoklee commented Apr 27, 2023

Uh oh!

spackbot-app bot commented Apr 27, 2023

Uh oh!

hyoklee commented Apr 27, 2023

Uh oh!

Uh oh!

alalazo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hyoklee commented May 11, 2023

Uh oh!

hyoklee commented May 15, 2023

Uh oh!

kwryankrattiger left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hyoklee commented Feb 23, 2023 •

edited by tldahlgren

Loading

hyoklee commented Mar 1, 2023 •

edited

Loading