Skip to content

hpcviewer: add version 2023.02#35648

Merged
tldahlgren merged 1 commit intospack:developfrom
mwkrentel:krentel/viewer-2023.02
Feb 28, 2023
Merged

hpcviewer: add version 2023.02#35648
tldahlgren merged 1 commit intospack:developfrom
mwkrentel:krentel/viewer-2023.02

Conversation

@mwkrentel
Copy link
Copy Markdown
Member

No description provided.

tldahlgren
tldahlgren previously approved these changes Feb 23, 2023
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed one of the sha256, rest I'll take on faith. 😉

@tldahlgren tldahlgren self-assigned this Feb 23, 2023
@tldahlgren tldahlgren enabled auto-merge (squash) February 23, 2023 20:31
@mwkrentel
Copy link
Copy Markdown
Member Author

@tldahlgren The reason CI failed is that it tries to build hpctoolkit with
hpcviewer as a dependency. That fails because the url patch changed
its checksum from gitlab.

I have another PR #35662 which should "fix" the checksum,
except that it won't actually fix it, it will turn that case into a
conflict. I'll have to see how the concretizer reacts to that.

Anyway, I think I can fix the CI, but I have to fix it by getting the
other PR merged. But since you turned on auto-merge, there's a decent
chance I can fix it without further action from you. yeah!

auto-merge was automatically disabled February 25, 2023 16:28

Head branch was pushed to by a user without write access

@mwkrentel
Copy link
Copy Markdown
Member Author

The new sha256 sums for hpctoolkit are from #35662.
But they seem to be blocking this commit.

@mwkrentel
Copy link
Copy Markdown
Member Author

@tldahlgren I fixed the sha256 sums from #35662 and now it passes the CI tests.
If you could re-approve/merge, that would finish the viewer release.
Thanks!

@mwkrentel mwkrentel force-pushed the krentel/viewer-2023.02 branch from 6d6e646 to 2aa2cc3 Compare February 27, 2023 15:31
@mwkrentel
Copy link
Copy Markdown
Member Author

@tldahlgren Well, Harmen converted the URL patches to actual patches
in #35711 (while I was asleep). So, I reverted the last commit here
for updating the checksums.

So, now we're back to the original patch which I expect should pass CI.

@mwkrentel
Copy link
Copy Markdown
Member Author

@tldahlgren Ready to merge. Thanks.

@tldahlgren tldahlgren merged commit 043a80f into spack:develop Feb 28, 2023
koysean pushed a commit to koysean/spack that referenced this pull request Mar 7, 2023
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants