singularity-eos: Fix Cray CCE fortran module naming#35625
Merged
alalazo merged 1 commit intospack:developfrom Mar 8, 2023
Merged
singularity-eos: Fix Cray CCE fortran module naming#35625alalazo merged 1 commit intospack:developfrom
alalazo merged 1 commit intospack:developfrom
Conversation
rbberger
previously approved these changes
Mar 3, 2023
Member
rbberger
left a comment
rbberger
left a comment
There was a problem hiding this comment.
Maybe just rebase to clean up the history.
The Cray fortran compiler names fortran modules in uppercase by default. Compile with the "-ef" flag to produce the lowercase name that singularity-eos is expecting.
quellyn
force-pushed
the
singularity-eos/cray-fortran-module-naming
branch
from
abe4787 to
b306403
Compare
rbberger
approved these changes
Mar 3, 2023
alalazo
approved these changes
Mar 8, 2023
jmcarcell
pushed a commit
to key4hep/spack
that referenced
this pull request
Apr 13, 2023
The Cray fortran compiler names fortran modules in uppercase by default. Compile with the "-ef" flag to produce the lowercase name that singularity-eos is expecting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default the Cray CCE Fortran compiler names Fortran module files in uppercase (e.g., "MODULENAME.mod").
However,
singularity-eosappears to be expecting a lowercase name:file INSTALL cannot find "/tmp/quellyn/spack-stage/spack-stage-singularity-eos-1.6.2-xlpm47zdhk32jyblj5j4ej4ibprmbepv/spack-build-xlpm47z/singularity_eos.mod": No such file or directory.Using the "-ef" compiler flag to override this behavior and produce modulefile names in lowercase, e.g. "modulename.mod") solves this issue.
Tested on a Cray EX system (LLNL RZVernal, CCE 15.0.1) and also on a non-Cray system (LANL Darwin, Intel Skylake, GCC 8.5.0).
@rbberger, @DarylGrunau