Add support for mfem cuda build#35608
Merged
alalazo merged 2 commits intospack:developfrom Mar 8, 2023
aaroncblack:feature/aaroncblack/mfem_4.5_cuda_support
Merged
Add support for mfem cuda build#35608alalazo merged 2 commits intospack:developfrom aaroncblack:feature/aaroncblack/mfem_4.5_cuda_support
alalazo merged 2 commits intospack:developfrom
aaroncblack:feature/aaroncblack/mfem_4.5_cuda_support
Conversation
spackbot-app
bot
requested review from
acfisher,
goxberry,
markcmiller86,
tzanio and
v-dobrev
Contributor
Author
v-dobrev
previously approved these changes
Feb 23, 2023
Member
v-dobrev
left a comment
v-dobrev
left a comment
There was a problem hiding this comment.
Thanks @aaroncblack, this looks good and it should be fine with older hypre versions too.
Contributor
Author
v-dobrev
previously approved these changes
Feb 23, 2023
Member
|
I think I have permission to merge this after all PR checks pass, however I typically wait for someone from the Spack team to do it since I'm not familiar with all the policies on merging. |
alalazo
approved these changes
Mar 1, 2023
v-dobrev
approved these changes
Mar 3, 2023
Member
|
@alalazo, I tried hitting the "Update branch" button to get clean CI checks to trigger the auto-merge but that did not work. What can we do to get this merged? |
Member
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
Member
|
Tried re-running the two spuriously failed builds. |
jmcarcell
pushed a commit
to key4hep/spack
that referenced
this pull request
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing 'cublas' dependency in MFEM library spack build.