Skip to content

cp2k: fix builds on macOS, workaround reported issue with __contains__#35584

Merged
alalazo merged 6 commits intospack:developfrom
dev-zero:bugfix/cp2k-on-macos
Mar 1, 2023
Merged

cp2k: fix builds on macOS, workaround reported issue with __contains__#35584
alalazo merged 6 commits intospack:developfrom
dev-zero:bugfix/cp2k-on-macos

Conversation

@dev-zero
Copy link
Copy Markdown
Contributor

@dev-zero dev-zero commented Feb 20, 2023

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Feb 20, 2023

Hi @dev-zero! I noticed that the following package(s) don't yet have maintainers:

  • netlib-scalapack

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("dev-zero")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame netlib-scalapack

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@dev-zero
Copy link
Copy Markdown
Contributor Author

for cp2k and netlib-scalapack @alalazo or @haampie ?

rscohn2
rscohn2 previously approved these changes Feb 20, 2023
Copy link
Copy Markdown
Member

@rscohn2 rscohn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM. One question and one minor suggestion

@alalazo alalazo self-assigned this Feb 20, 2023
@dev-zero dev-zero force-pushed the bugfix/cp2k-on-macos branch from 9c473cf to ce9c2ac Compare February 21, 2023 08:51
@alalazo alalazo changed the title bugfix/cp2k on macos cp2k: fix builds on macOS, workaround reported issue with __contains__ Feb 21, 2023
@alalazo alalazo force-pushed the bugfix/cp2k-on-macos branch from ce9c2ac to 2f85092 Compare February 28, 2023 09:55
@alalazo
Copy link
Copy Markdown
Member

alalazo commented Mar 1, 2023

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Mar 1, 2023

I've started that pipeline for you!

@alalazo alalazo enabled auto-merge (squash) March 1, 2023 13:42
@alalazo
Copy link
Copy Markdown
Member

alalazo commented Mar 1, 2023

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Mar 1, 2023

I've started that pipeline for you!

@alalazo alalazo merged commit 44705b0 into spack:develop Mar 1, 2023
koysean pushed a commit to koysean/spack that referenced this pull request Mar 7, 2023
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants