gitlab: push public key to mirror after signing specs#35409
Closed
scottwittenburg wants to merge 1 commit intospack:developfrom
Closed
gitlab: push public key to mirror after signing specs#35409scottwittenburg wants to merge 1 commit intospack:developfrom
scottwittenburg wants to merge 1 commit intospack:developfrom
Conversation
spackbot-app
bot
added
core
Contributor
Author
|
@kwryankrattiger I can't wait for that boiler plate reduction PR to land and put an end to PRs like this one! |
Member
|
@scottwittenburg since this is not tested and won't be tested even if you drop the draft status I'm not going to backport it to 0.19.1 |
Contributor
Author
Just making sure we're on the same page: you're right this won't be tested in the PR, and won't be tested until a protected pipeline runs with the change.
I think that's fine. As I mentioned in chat, I can manually push public key anywhere we need it for the current point release. |
kwryankrattiger
added a commit
to kwryankrattiger/spack
that referenced
this pull request
Feb 10, 2023
kwryankrattiger
added a commit
to kwryankrattiger/spack
that referenced
this pull request
Feb 10, 2023
kwryankrattiger
added a commit
to kwryankrattiger/spack
that referenced
this pull request
Feb 17, 2023
kwryankrattiger
added a commit
to kwryankrattiger/spack
that referenced
this pull request
Feb 24, 2023
kwryankrattiger
added a commit
to kwryankrattiger/spack
that referenced
this pull request
Mar 7, 2023
kwryankrattiger
added a commit
that referenced
this pull request
Mar 10, 2023
* CI configuration boilerplate reduction and refactor Configuration: - New notation for list concatenation (prepend/append) - New notation for string concatenation (prepend/append) - Break out configuration files for: ci.yaml, cdash.yaml, view.yaml - Spack CI section refactored to improve self-consistency and composability - Scripts are now lists of lists and/or lists of strings - Job attributes are now listed under precedence ordered list that are composed/merged using Spack config merge rules. - "service-jobs" are identified explicitly rather than as a batch CI: - Consolidate common, platform, and architecture configurations for all CI stacks into composable configuration files - Make padding consistent across all stacks (256) - Merge all package -> runner mappings to be consistent across all stacks Unit Test: - Refactor CI module unit-tests for refactor configuration Docs: - Add docs for new notations in configuration.rst - Rewrite docs on CI pipelines to be consistent with refactored CI workflow * Script verbose environ, dev bootstrap * Port #35409
Member
|
What's the status here? |
jmcarcell
pushed a commit
to key4hep/spack
that referenced
this pull request
Apr 13, 2023
* CI configuration boilerplate reduction and refactor Configuration: - New notation for list concatenation (prepend/append) - New notation for string concatenation (prepend/append) - Break out configuration files for: ci.yaml, cdash.yaml, view.yaml - Spack CI section refactored to improve self-consistency and composability - Scripts are now lists of lists and/or lists of strings - Job attributes are now listed under precedence ordered list that are composed/merged using Spack config merge rules. - "service-jobs" are identified explicitly rather than as a batch CI: - Consolidate common, platform, and architecture configurations for all CI stacks into composable configuration files - Make padding consistent across all stacks (256) - Merge all package -> runner mappings to be consistent across all stacks Unit Test: - Refactor CI module unit-tests for refactor configuration Docs: - Add docs for new notations in configuration.rst - Rewrite docs on CI pipelines to be consistent with refactored CI workflow * Script verbose environ, dev bootstrap * Port spack#35409
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assuming we can have the signing job export the public part of the reputational signing key, here, this change will make sure that public key is placed into the expected location in the mirror after the signing script finishes.
Since pipelines follow up the signing job with a rebuild index job, which notably includes the
--keysargument, that should take care of indexing the new key once it's in place.