Merged
Conversation
adamjstewart
added
checksum
MichaelLaufer
approved these changes
Feb 8, 2023
Contributor
MichaelLaufer
left a comment
MichaelLaufer
left a comment
There was a problem hiding this comment.
Looking at the WRF releases page:
https://github.com/wrf-model/WRF/releases
It appears that the v4.4.2.tar.gz file was updated/reuploaded just 5 days ago (so after @t-brown 's PR, #35244), I assume this explains what we are seeing.
That being said it looks like a 1-time issue, and we can proceed with updating the hash on our end.
tldahlgren
approved these changes
Feb 8, 2023
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Confirmed the new sha256.
Member
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
Merged
tldahlgren
pushed a commit
to tldahlgren/spack
that referenced
this pull request
Feb 13, 2023
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
techxdave
pushed a commit
to Tech-XCorp/spack
that referenced
this pull request
Feb 17, 2023
jmcarcell
pushed a commit
to key4hep/spack
that referenced
this pull request
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WRF 4.4.2 checksum seems to have changed since it was added in #35244. Not sure if this is due to the recent GitHub hashing change or not. I have a feeling it isn't since that should only affect the auto-generated tarballs, not the manually uploaded assets. Should I open an issue with the WRF developers to investigate?
(the previous checksum does not match any of the other tar or zip, auto or manual downloads)
CI is currently failing because of this: https://gitlab.spack.io/spack/spack/-/jobs/5466213
@t-brown @tldahlgren