Skip to content

rocm: detect amdgpu_target in external find#35316

Closed
cgmb wants to merge 1 commit intospack:developfrom
cgmb:amdgpu-target-external
Closed

rocm: detect amdgpu_target in external find#35316
cgmb wants to merge 1 commit intospack:developfrom
cgmb:amdgpu-target-external

Conversation

@cgmb
Copy link
Copy Markdown
Contributor

@cgmb cgmb commented Feb 3, 2023

This is a working proof-of-concept for determining the amdgpu_target variant from spack external find.

@spackbot-app spackbot-app bot added build-systems core PR affects Spack core functionality update-package labels Feb 3, 2023
@cgmb cgmb marked this pull request as ready for review March 1, 2023 18:29
@cgmb
Copy link
Copy Markdown
Contributor Author

cgmb commented Mar 1, 2023

It's not exactly beautiful code, but it works.

@haampie, @renjithravindrankannath, @srekolam: could you maybe take a look at this and let me know what sort of changes you feel are necessary.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Jun 15, 2025

Closing, since there has been no activity in a while. Feel free to migrate the PR / reopen at https://github.com/spack/spack-packages if you want to continue work on this.

@alalazo alalazo closed this Jun 15, 2025
@alalazo alalazo added the ROCm/hip Support for ROCm/hip label Jun 15, 2025
@alalazo
Copy link
Copy Markdown
Member

alalazo commented Jun 15, 2025

We can also think of adding some similar functionality to archspec, if it makes sense to you

@cgmb
Copy link
Copy Markdown
Contributor Author

cgmb commented Jun 16, 2025

Closing, since there has been no activity in a while. Feel free to migrate the PR / reopen at https://github.com/spack/spack-packages if you want to continue work on this.

There's not much motivation for me to work on this when nobody seems interested. I still think it's a good feature, but somebody else should pick it up if they want this.

I suppose that it's extra relevant now that ROCm has been packaged by all major distros. The GPU target list is not necessarily always the same as AMD upstream even for the same versions.

We can also think of adding some similar functionality to archspec, if it makes sense to you

Works for me. If you can depend on llvm-objdump, you might find that is a better basis for implementing this functionality rather than parsing the binary directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-systems core PR affects Spack core functionality ROCm/hip Support for ROCm/hip update-package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants