rocm: detect amdgpu_target in external find#35316
Conversation
|
It's not exactly beautiful code, but it works. @haampie, @renjithravindrankannath, @srekolam: could you maybe take a look at this and let me know what sort of changes you feel are necessary. |
|
Closing, since there has been no activity in a while. Feel free to migrate the PR / reopen at https://github.com/spack/spack-packages if you want to continue work on this. |
|
We can also think of adding some similar functionality to |
There's not much motivation for me to work on this when nobody seems interested. I still think it's a good feature, but somebody else should pick it up if they want this. I suppose that it's extra relevant now that ROCm has been packaged by all major distros. The GPU target list is not necessarily always the same as AMD upstream even for the same versions.
Works for me. If you can depend on llvm-objdump, you might find that is a better basis for implementing this functionality rather than parsing the binary directly. |
This is a working proof-of-concept for determining the amdgpu_target variant from
spack external find.