Skip to content

[WRF] Adding new versions#35244

Merged
tldahlgren merged 4 commits intospack:developfrom
t-brown:develop
Feb 1, 2023
Merged

[WRF] Adding new versions#35244
tldahlgren merged 4 commits intospack:developfrom
t-brown:develop

Conversation

@t-brown
Copy link
Copy Markdown
Contributor

@t-brown t-brown commented Jan 30, 2023

No description provided.

tldahlgren
tldahlgren reviewed Jan 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the sha256 for 4.4.2 and 4.4 BUT spack checksum is yielding different sha256 for all of the other listed versions. Any idea why?

@tldahlgren tldahlgren self-assigned this Jan 30, 2023
@tldahlgren
Copy link
Copy Markdown
Contributor

tldahlgren commented Jan 31, 2023

I confirmed the sha256 for 4.4.2 and 4.4 BUT spack checksum is yielding different sha256 for all of the other listed versions. Any idea why?

Heard GitHub reverted their hash algorithm change that caused these issues.

tldahlgren
tldahlgren approved these changes Jan 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed new (and re-confirmed existing) sha256.

@tldahlgren
Copy link
Copy Markdown
Contributor

tldahlgren commented Jan 31, 2023

Deferring merge decision to give @MichaelLaufer and or @ptooley a chance to review.

@tldahlgren
Copy link
Copy Markdown
Contributor

tldahlgren commented Jan 31, 2023

For future reference, we would appreciate PRs from branches (see https://spack.readthedocs.io/en/latest/contribution_guide.html#git-workflows).

MichaelLaufer
MichaelLaufer approved these changes Feb 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@MichaelLaufer MichaelLaufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tldahlgren tldahlgren merged commit 002bd8d into spack:develop Feb 1, 2023
@adamjstewart adamjstewart mentioned this pull request Feb 8, 2023
Merged
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
@t-brown
[WRF] Adding new versions (spack#35244)
f880395 
* [WRF] Adding new versions.
* Style fixes.
techxdave pushed a commit to Tech-XCorp/spack that referenced this pull request Feb 17, 2023
@t-brown @techxdave
[WRF] Adding new versions (spack#35244)
b994fec 
* [WRF] Adding new versions.
* Style fixes.
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
@t-brown @jmcarcell
[WRF] Adding new versions (spack#35244)
a9bcdf0 
* [WRF] Adding new versions.
* Style fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tldahlgren tldahlgren tldahlgren approved these changes

@ptooley ptooley Awaiting requested review from ptooley

+1 more reviewer

@MichaelLaufer MichaelLaufer MichaelLaufer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tldahlgren tldahlgren

@MichaelLaufer MichaelLaufer

Labels

new-version patch update-package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@t-brown @tldahlgren @MichaelLaufer