Conversation
spackbot-app
bot
added
binary-packages
build-systems
commands
conflicts
core
spackbot-app
bot
requested review from
adamjstewart,
danlipsa,
dev-zero,
jeanbez,
kabicm,
lkurz,
lpottier,
lrknox,
mathomp4,
pradyunsg,
ptooley and
renjithravindrankannath
| version("1.13.3", sha256="83c7c06671f975cee6944b0b217f95005faa55f79ea5532cf4ac268989866af4") | ||
| # NOTE: retain version 1.13.2 until: | ||
| # 1. hdf5-vol-async, hdf5-vol-cache, and hdf5-vol-log are ready to build off | ||
| # [email protected]+ (VOL struct underwent breaking changes). |
There was a problem hiding this comment.
Probably should be "...ready to build off [email protected]+
There was a problem hiding this comment.
I was going to ask if this was still needed for the VOL adapters. I would prefer to delete this entirely if possible.
I want to say we had a discussion that all of the vols were ready for 1.14, but I don't trust my memory.
There was a problem hiding this comment.
All are ready except hdf5-vol-external-passthrough. I don't think that one is of great importance to anyone outside of hdf5. I can try to update it this afternoon, so you can wait for the update, or go ahead without it. As I recall we kept hdf51.13.2 so e4s tests would pass - probably Paraview in particular.
There was a problem hiding this comment.
I don't think that gets built via any of the spack CI stacks, so it should be okay to follow-up with that.
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
|
@alalazo The only thing stopping this PR is CI being extremely reliably flakey when downloading and installing dependencies from the mirror. I really don't understand why this is happening, Any ideas? I thought it might be key related, but I thought all of that was fixed now. |
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Confirmed the new sha256 (for py-h5py) though have a question about a change.
|
@adamjstewart Did you want to review the |
|
@adamjstewart I dropped the py-h5py from this PR in favor of the other one #35960 , so this work won't build until that goes in. |
- When +hdf5, enable VOL adapters suitable for the SDK.
- Each VOL package must prepend to the HDF5_PLUGIN_PATH.
- hdf5: 1.13.3 will break existing VOL packages, constrain
VOLs related to SDK and add note to keep 1.13.2 available.
- hdf5-vol-async:
- Do not set HDF5_VOL_CONNECTOR, consumers must opt-in.
- Enforce DAG constraints on MPI to require threaded version.
- Depend on an explicit version of argbots to relax
concretization issues in other spack environments.
- paraview: fix compiler flag usage for the 110 ABI (followup to spack#33617).
|
@tldahlgren could you give this the last approval nudge? |
8 participants
Reviving #33393 now that HDF5 1.14 is released and ParaView has been patched for new HDF5