Skip to content

py-pytorch-lightning: add +extra variant#35121

Merged
adamjstewart merged 3 commits intospack:developfrom
adamjstewart:packages/py-pytorch-lightning-extra
Jan 25, 2023
Merged

py-pytorch-lightning: add +extra variant#35121
adamjstewart merged 3 commits intospack:developfrom
adamjstewart:packages/py-pytorch-lightning-extra

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

Successfully builds on macOS 10.15.7 with Python 3.10.8 and Apple Clang 12.0.0.

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jan 24, 2023

Hi @adamjstewart! I noticed that the following package(s) don't yet have maintainers:

  • py-docstring-parser
  • py-gcsfs
  • py-hydra-core
  • py-jsonargparse
  • py-onnxruntime
  • py-typeshed-client

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ["adamjstewart"]

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-docstring-parser

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@spackbot-app spackbot-app bot requested a review from calebrob6 January 24, 2023 05:13
compatibility."""
compatibility.

Deprecated in favor of py-onnxruntime.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the GitHub and PyPI are named onnxruntime, not onnx-runtime.

@adamjstewart
Copy link
Copy Markdown
Member Author

@tldahlgren I don't think it makes sense to assign me to my own PR 😆

@tldahlgren
Copy link
Copy Markdown
Contributor

@tldahlgren I don't think it makes sense to assign me to my own PR 😆

🤦‍♀️

Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed new/modified sha256 and tags.

@tldahlgren tldahlgren self-assigned this Jan 25, 2023
@adamjstewart adamjstewart merged commit 80f3888 into spack:develop Jan 25, 2023
@adamjstewart adamjstewart deleted the packages/py-pytorch-lightning-extra branch January 25, 2023 21:58
kwryankrattiger pushed a commit to kwryankrattiger/spack that referenced this pull request Jan 27, 2023
* py-pytorch-lightning: add +extra variant

* Update dependencies

* py-fsspec: add v2023.1.0
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
* py-pytorch-lightning: add +extra variant

* Update dependencies

* py-fsspec: add v2023.1.0
techxdave pushed a commit to Tech-XCorp/spack that referenced this pull request Feb 17, 2023
* py-pytorch-lightning: add +extra variant

* Update dependencies

* py-fsspec: add v2023.1.0
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
* py-pytorch-lightning: add +extra variant

* Update dependencies

* py-fsspec: add v2023.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants