Skip to content

Windows: Port lz4#35101

Merged
scheibelp merged 1 commit intospack:developfrom
johnwparent:win/port-lz4
Mar 20, 2023
Merged

Windows: Port lz4#35101
scheibelp merged 1 commit intospack:developfrom
johnwparent:win/port-lz4

Conversation

@johnwparent
Copy link
Copy Markdown
Contributor

lz4 - add CMake build system

lz4 build in serial on Windows - otherwise there is a transient build error caused by Ninja over parallelizing the build and dependent targets being built out of order due to the structure of the lz4 CMake system.

lz4 - multi buildsystem refactor

Part of #34938

lz4 serial on Windows

lz4 - multi buildsystem
@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jan 23, 2023

Hi @johnwparent! I noticed that the following package(s) don't yet have maintainers:

  • lz4

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ["johnwparent"]

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame lz4

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@scheibelp scheibelp merged commit fa0749b into spack:develop Mar 20, 2023
Comment on lines +59 to +62
@run_after("install")
def darwin_fix(self):
if sys.platform == "darwin":
fix_darwin_install_name(self.prefix.lib)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you add builders, these methods should be on the builders (otherwise they are not taken into consideration). I'll check how easy it is to add an audit for stuff like this.

alalazo added a commit to alalazo/spack that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants