Skip to content

Revert "Allow spec.json files to be clearsigned, use transparent compression for *.json"#34856

Merged
alalazo merged 1 commit intodevelopfrom
revert-34490-binary_cache/allow-clearsigned-spec.json-files
Jan 9, 2023
Merged

Revert "Allow spec.json files to be clearsigned, use transparent compression for *.json"#34856
alalazo merged 1 commit intodevelopfrom
revert-34490-binary_cache/allow-clearsigned-spec.json-files

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Jan 9, 2023 •
edited
Loading

Reverts #34490

  File "/builds/spack/spack/lib/spack/spack/binary_distribution.py", line 2043, in try_direct_fetch
    stream = transparently_decompress_bytes_to_string(fs)
  File "/builds/spack/spack/lib/spack/spack/binary_distribution.py", line 637, in transparently_decompress_bytes_to_string
    return codecs.getreader(encoding)(transparently_decompress_bytes(binary_stream))
  File "/builds/spack/spack/lib/spack/spack/binary_distribution.py", line 628, in transparently_decompress_bytes
    magic = binary_stream.peek(2)
  File "/usr/lib64/python3.7/tempfile.py", line 481, in func_wrapper
    return func(*args, **kwargs)
AttributeError: 'StreamingBody' object has no attribute 'readinto'

CI may have an old boto version that doesn't support peek?

@spackbot-app spackbot-app bot added binary-packages commands core PR affects Spack core functionality tests General test capability(ies) labels Jan 9, 2023
@alalazo alalazo merged commit 47011f5 into develop Jan 9, 2023
@alalazo alalazo deleted the revert-34490-binary_cache/allow-clearsigned-spec.json-files branch January 9, 2023 09:52
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 24, 2023
@haampie @RikkiButler20
Revert "Allow spec.json files to be clearsigned, use transparent comp…
c7b24f2 
…ression for *.json (spack#34490)" (spack#34856)

This reverts commit 8a1b817.
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
@haampie
Revert "Allow spec.json files to be clearsigned, use transparent comp…
7a31200 
…ression for *.json (spack#34490)" (spack#34856)

This reverts commit 8a1b817.
techxdave pushed a commit to Tech-XCorp/spack that referenced this pull request Feb 17, 2023
@haampie @techxdave
Revert "Allow spec.json files to be clearsigned, use transparent comp…
efb7df8 
…ression for *.json (spack#34490)" (spack#34856)

This reverts commit 8a1b817.
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
@haampie @jmcarcell
Revert "Allow spec.json files to be clearsigned, use transparent comp…
2a2ce42 
…ression for *.json (spack#34490)" (spack#34856)

This reverts commit 8a1b817.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalazo alalazo alalazo approved these changes

Assignees

No one assigned

Labels

binary-packages commands core PR affects Spack core functionality tests General test capability(ies)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haampie @alalazo