Closed
Conversation
adamjstewart
requested changes
Mar 17, 2017
| depends_on('glew') | ||
| depends_on('jpeg') | ||
| depends_on('libpng') | ||
| depends_on('doxygen') |
Member
There was a problem hiding this comment.
Does this package link to doxygen, or does it just need it to build the documentation? If it's the latter, this should be a build dependency:
depends_on('doxygen', type='build')| depends_on('libpng') | ||
| depends_on('doxygen') | ||
| depends_on('libxml2') | ||
| depends_on('py-pyqt') |
Member
There was a problem hiding this comment.
You probably want:
depends_on('py-pyqt', type=('build', 'run'))
Member
|
Ping @kisaacs |
Member
|
ping @kisaacs |
healther
suggested changes
Mar 23, 2018
| depends_on('py-pyqt') | ||
|
|
||
| @run_after('install') | ||
| def relocate_python(self): |
Contributor
There was a problem hiding this comment.
Isn't this what spack activate tulip is supposed to be doing? If I read this correctly this would write directly in the prefix of the python dependency
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Apr 27, 2020
closes spack#3479 Co-authored-by: Kate Isaacs <[email protected]>
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Apr 27, 2020
closes spack#3479 Co-authored-by: Kate Isaacs <[email protected]>
adamjstewart
pushed a commit
that referenced
this pull request
Apr 27, 2020
closes #3479 Co-authored-by: Kate Isaacs <[email protected]> Co-authored-by: Kate Isaacs <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a package for Tulip.