Conversation
spackbot-app
bot
added
commands
core
tgamblin
force-pushed
the
fix-git-in-tests
branch
from
cf1bb9a to
e5153a8
Compare
tgamblin
force-pushed
the
fix-git-in-tests
branch
from
e5153a8 to
63448f4
Compare
alalazo
reviewed
Dec 27, 2022
Member
There was a problem hiding this comment.
This basically LGTM. I just left a few minor comments:
- The rename
spack.util.git.get_git()->spack.util.git.git()is absolutely minor. I think we are pretty inconsistent at the moment, so I'd be fine with either if you prefer the current state. - I need to double check if
skipifcan be applied on a fixture (I can't find clear docs on it, all the examples seem to suggest we need to use the imperative method during the setup phase)
Other than that it's 💯 to unify code!
Comment on lines
+23
to
+30
| # If we're running under pytest, add this to ignore the fix for CVE-2022-39253 in | ||
| # git 2.38.1+. Do this in one place; we need git to do this in all parts of Spack. | ||
| if "pytest" in sys.modules: | ||
| git.add_default_arg("-c") | ||
| git.add_default_arg("protocol.file.allow=always") |
Member
There was a problem hiding this comment.
Should we work around a CVE without letting users know? Where would this be relevant besides CI?
Member
Author
There was a problem hiding this comment.
We know the CVE doesn't affect us because it's not a multi-user environment and we created the directories ourselves.
Member
Author
|
@alalazo all should be fixed |
tgamblin
force-pushed
the
fix-git-in-tests
branch
2 times, most recently
from
48a8607 to
55b15cf
Compare
spackbot-app
bot
added
the
documentation
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git 2.38.1 or higher, due to a fix for `CVE-2022-39253`. This was fixed in CI in #33429, but that doesn't help the issue for anyone's local environment. Instead of fixing this with git config in CI, we should ensure that the tests run anywhere. - [x] Introduce `spack.util.git`. - [x] Use `spack.util.git.get_git()` to get a `git` executable, instead of using `which("git")` everywhere. - [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`. - [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`. - [x] Revert changes from #33429, which are no longer needed.
tgamblin
force-pushed
the
fix-git-in-tests
branch
3 times, most recently
from
69ce8ed to
bb4cdee
Compare
tgamblin
force-pushed
the
fix-git-in-tests
branch
from
bb4cdee to
87f9dda
Compare
Member
Author
|
@alalazo I can't seem to get past this sphinx issue for It doesn't seem to matter if it's fully qualified or if I add it to But everything else is done. |
alalazo
approved these changes
Dec 28, 2022
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
Sphinx tests seems to be passing on readthedocs. I think this one just needs to pass Gitlab, once it is available again.
stephenmsachs
pushed a commit
to stephenmsachs/spack
that referenced
this pull request
Jan 3, 2023
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git 2.38.1 or higher, due to a fix for `CVE-2022-39253`. This was fixed in CI in spack#33429, but that doesn't help the issue for anyone's local environment. Instead of fixing this with git config in CI, we should ensure that the tests run anywhere. - [x] Introduce `spack.util.git`. - [x] Use `spack.util.git.get_git()` to get a git executable, instead of `which("git")` everywhere. - [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`. - [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`. - [x] Revert changes from spack#33429, which are no longer needed.
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 24, 2023
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git 2.38.1 or higher, due to a fix for `CVE-2022-39253`. This was fixed in CI in spack#33429, but that doesn't help the issue for anyone's local environment. Instead of fixing this with git config in CI, we should ensure that the tests run anywhere. - [x] Introduce `spack.util.git`. - [x] Use `spack.util.git.get_git()` to get a git executable, instead of `which("git")` everywhere. - [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`. - [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`. - [x] Revert changes from spack#33429, which are no longer needed.
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git 2.38.1 or higher, due to a fix for `CVE-2022-39253`. This was fixed in CI in spack#33429, but that doesn't help the issue for anyone's local environment. Instead of fixing this with git config in CI, we should ensure that the tests run anywhere. - [x] Introduce `spack.util.git`. - [x] Use `spack.util.git.get_git()` to get a git executable, instead of `which("git")` everywhere. - [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`. - [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`. - [x] Revert changes from spack#33429, which are no longer needed.
techxdave
pushed a commit
to Tech-XCorp/spack
that referenced
this pull request
Feb 17, 2023
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git 2.38.1 or higher, due to a fix for `CVE-2022-39253`. This was fixed in CI in spack#33429, but that doesn't help the issue for anyone's local environment. Instead of fixing this with git config in CI, we should ensure that the tests run anywhere. - [x] Introduce `spack.util.git`. - [x] Use `spack.util.git.get_git()` to get a git executable, instead of `which("git")` everywhere. - [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`. - [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`. - [x] Revert changes from spack#33429, which are no longer needed.
jmcarcell
pushed a commit
to key4hep/spack
that referenced
this pull request
Apr 13, 2023
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git 2.38.1 or higher, due to a fix for `CVE-2022-39253`. This was fixed in CI in spack#33429, but that doesn't help the issue for anyone's local environment. Instead of fixing this with git config in CI, we should ensure that the tests run anywhere. - [x] Introduce `spack.util.git`. - [x] Use `spack.util.git.get_git()` to get a git executable, instead of `which("git")` everywhere. - [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`. - [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`. - [x] Revert changes from spack#33429, which are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local
gittests will fail withfatal: transport 'file' not allowedwhen using git 2.38.1 or higher, due to a fix forCVE-2022-39253.This was fixed in CI in #33429, but that doesn't help the issue for anyone's local environment. Instead of fixing this with git config in CI, we should ensure that the tests run anywhere.
spack.util.git.spack.util.git.get_git()to get a git executable, instead ofwhich("git")everywhere.gittests use agitfixture that goes throughspack.util.git.get_git().-c protocol.file.allow=alwaysto allgitinvocations underpytest.