Skip to content

Boost: add version 1.81.0#34613

Merged
alalazo merged 1 commit intospack:developfrom
hainest:boost_1_81_0
Mar 8, 2023
Merged

Boost: add version 1.81.0#34613
alalazo merged 1 commit intospack:developfrom
hainest:boost_1_81_0

Conversation

@hainest
Copy link
Copy Markdown
Contributor

@hainest hainest commented Dec 19, 2022

No description provided.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Dec 21, 2022

@spackbot run pipeline

@alalazo alalazo self-assigned this Dec 21, 2022
@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Dec 21, 2022

I've started that pipeline for you!

alalazo
alalazo previously approved these changes Dec 21, 2022
@alalazo alalazo enabled auto-merge (squash) December 21, 2022 19:12
@hainest
Copy link
Copy Markdown
Contributor Author

hainest commented Dec 21, 2022

@alalazo The change here didn't break the pipeline. I need to try to fix that PCH issue with %oneapi so we don't have to keep dealing with it on all of the Boost changes.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Dec 22, 2022

Can we work around that PCH issue for oneapi, until a proper fix is ready?

auto-merge was automatically disabled December 29, 2022 16:11

Head branch was pushed to by a user without write access

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Jan 16, 2023

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jan 16, 2023

I've started that pipeline for you!

@hainest
Copy link
Copy Markdown
Contributor Author

hainest commented Jan 16, 2023

@alalazo The Dyninst build failure in ci/gitlab-ci is a known issue and has been fixed in dyninst/master. We can merge here.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Jan 16, 2023

Ok, can you constrain the version of boost that dyninst can use in this PR, so that pipelines pass? After that this is mergeable.

@hainest
Copy link
Copy Markdown
Contributor Author

hainest commented Jan 16, 2023

Ok, can you constrain the version of boost that dyninst can use in this PR, so that pipelines pass? After that this is mergeable.

It's not a Boost issue, it's an STL one. Newer versions of gcc and clang have cleaned up the transitive includes of their STL headers. There are a couple of places in Dyninst that were affected by this.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Jan 17, 2023

It's not a Boost issue, it's an STL one. Newer versions of gcc and clang have cleaned up the transitive includes of their STL headers. There are a couple of places in Dyninst that were affected by this.

Do we know why this built in the first place then?1 I'd like to double check why dyninst was ✔️ at some point, before force merging something that will break CI on develop.

Footnotes

  1. I didn't look at the logs in the previous comment, and thought it was a known incompatibility between recent boost and dyninst

@hainest
Copy link
Copy Markdown
Contributor Author

hainest commented Feb 22, 2023

@alalazo The pipeline stall here will be fixed by #35630

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Mar 2, 2023

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Mar 2, 2023

I've started that pipeline for you!

@hainest
Copy link
Copy Markdown
Contributor Author

hainest commented Mar 6, 2023

@alalazo Boost 1.82.0 is coming out next week. This is working now, so we can merge. Thanks for the help!

@alalazo alalazo merged commit a93d143 into spack:develop Mar 8, 2023
@alalazo
Copy link
Copy Markdown
Member

alalazo commented Mar 8, 2023

Thanks @hainest !

@hainest hainest deleted the boost_1_81_0 branch March 23, 2023 18:36
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants