hpctoolkit: replace filter_file with upstream patch#34604
Merged
alalazo merged 1 commit intospack:developfrom Dec 21, 2022
Merged
hpctoolkit: replace filter_file with upstream patch#34604alalazo merged 1 commit intospack:developfrom
alalazo merged 1 commit intospack:developfrom
Conversation
Replace the filter_file for older configure with rocm 5.3 with an upstream patch. Further, the patch is no longer needed for develop or later releases.
renjithravindrankannath
approved these changes
Dec 19, 2022
Contributor
renjithravindrankannath
left a comment
renjithravindrankannath
left a comment
There was a problem hiding this comment.
Looks good to me.
alalazo
approved these changes
Dec 21, 2022
stephenmsachs
pushed a commit
to stephenmsachs/spack
that referenced
this pull request
Jan 3, 2023
Replace the filter_file for older configure with rocm 5.3 with an upstream patch. Further, the patch is no longer needed for develop or later releases.
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 24, 2023
Replace the filter_file for older configure with rocm 5.3 with an upstream patch. Further, the patch is no longer needed for develop or later releases.
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
Replace the filter_file for older configure with rocm 5.3 with an upstream patch. Further, the patch is no longer needed for develop or later releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the filter_file for older configure with rocm 5.3 with an upstream patch. Further, the patch is no longer needed for develop or later releases.