Merged
Conversation
tldahlgren
approved these changes
Dec 16, 2022
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Confirmed the sha256 for one of the platforms.
Will give @NickRF time to comment.
| version("21.0", sha256="60cfa7dd1cd131ec85e67cb660f2f84cf30bb700d8979cae1f5f88af658fd249") | ||
| elif platform.machine() == "x86_64": | ||
| version( | ||
| "22.1.2", sha256="baeac2b49c38547a8f3dd6a5237544eefe8c7695d969784e6f861ce77b610542" |
bernhardkaindl
approved these changes
Dec 16, 2022
Contributor
bernhardkaindl
left a comment
bernhardkaindl
left a comment
There was a problem hiding this comment.
22.1.2 built fine on Linux-arm64, so I think this looks good.
Contributor
Author
|
Can these changes be merged now? |
stephenmsachs
pushed a commit
to stephenmsachs/spack
that referenced
this pull request
Jan 3, 2023
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 24, 2023
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.