Add py-mlflow and its dependencies by heerener · Pull Request #34463 · spack/spack

heerener · 2022-12-12T13:19:47Z

No description provided.

spackbot-app · 2022-12-12T13:19:56Z

Hi @heerener! I noticed that the following package(s) don't yet have maintainers:

py-databricks-cli
py-gunicorn
py-mlflow
py-prometheus-flask-exporter
py-querystring-parser

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ["heerener"]

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-databricks-cli

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

tldahlgren

The ending year for the copyright for each package needs to be corrected (2020->2022). More importantly, there is a typo for py-databricks-cli pypi value.

var/spack/repos/builtin/packages/py-databricks-cli/package.py

var/spack/repos/builtin/packages/py-gunicorn/package.py

var/spack/repos/builtin/packages/py-mlflow/package.py

var/spack/repos/builtin/packages/py-prometheus-flask-exporter/package.py

var/spack/repos/builtin/packages/py-querystring-parser/package.py

var/spack/repos/builtin/packages/py-databricks-cli/package.py

tldahlgren · 2022-12-12T22:11:13Z

You'll also need to replace single quotes with double to pass the black checks.

adamjstewart

Style tests (single quotes instead of double quotes) can be fixed with spack style --fix -t black on the command line or @spackbot fix style on this PR. There's also a way to automatically update the licenses but I don't remember it.

var/spack/repos/builtin/packages/py-databricks-cli/package.py

var/spack/repos/builtin/packages/py-gunicorn/package.py

var/spack/repos/builtin/packages/py-mlflow/package.py

var/spack/repos/builtin/packages/py-prometheus-flask-exporter/package.py

var/spack/repos/builtin/packages/py-querystring-parser/package.py

Process review remarks, add missing dependencies, add skinny variant

var/spack/repos/builtin/packages/py-mlflow/package.py

Co-authored-by: Tamara Dahlgren <[email protected]> Co-authored-by: Adam J. Stewart <[email protected]>

heerener · 2022-12-13T13:46:22Z

@spackbot fix style

spackbot-app · 2022-12-13T13:46:25Z

Let me see if I can fix that for you!

spackbot-app · 2022-12-13T13:47:19Z

I was able to run spack style --fix for you!

spack style --fix

==> Running style checks on spack
  selected: isort, mypy, black, flake8
==> Modified files
  var/spack/repos/builtin/packages/py-databricks-cli/package.py
  var/spack/repos/builtin/packages/py-gunicorn/package.py
  var/spack/repos/builtin/packages/py-importlib-metadata/package.py
  var/spack/repos/builtin/packages/py-mlflow/package.py
  var/spack/repos/builtin/packages/py-prometheus-flask-exporter/package.py
  var/spack/repos/builtin/packages/py-pyarrow/package.py
  var/spack/repos/builtin/packages/py-querystring-parser/package.py
  var/spack/repos/builtin/packages/py-shap/package.py
  var/spack/repos/builtin/packages/py-waitress/package.py
==> Running isort checks
  isort checks were clean
==> Running mypy checks
lib/spack/llnl/util/lang.py:1064: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
lib/spack/spack/util/timer.py:68: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
lib/spack/spack/build_environment.py:291: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
lib/spack/spack/bootstrap/_common.py:52: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
Success: no issues found in 571 source files
  mypy checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/py-gunicorn/package.py
reformatted var/spack/repos/builtin/packages/py-prometheus-flask-exporter/package.py
reformatted var/spack/repos/builtin/packages/py-querystring-parser/package.py
reformatted var/spack/repos/builtin/packages/py-shap/package.py
reformatted var/spack/repos/builtin/packages/py-mlflow/package.py
All done! ✨ 🍰 ✨
5 files reformatted, 4 files left unchanged.
  black checks were clean
==> Running flake8 checks
var/spack/repos/builtin/packages/py-mlflow/package.py:21: [E501] line too long (112 > 99 characters)
var/spack/repos/builtin/packages/py-shap/package.py:10: [E501] line too long (119 > 99 characters)
  flake8 found errors

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

var/spack/repos/builtin/packages/py-mlflow/package.py

var/spack/repos/builtin/packages/py-pyarrow/package.py

var/spack/repos/builtin/packages/py-shap/package.py

var/spack/repos/builtin/packages/py-waitress/package.py

Co-authored-by: Adam J. Stewart <[email protected]>

var/spack/repos/builtin/packages/py-pyarrow/package.py

var/spack/repos/builtin/packages/py-shap/package.py

var/spack/repos/builtin/packages/py-slicer/package.py

It appears there are some issues when using `pip install` instead of `python setup.py` - this setup_build_environment should fix that.

var/spack/repos/builtin/packages/py-pyarrow/package.py

thomas-bouvier · 2023-01-27T14:50:30Z

For reference, I was working on adding package [email protected] there #35068 but stumbled upon difficulties related to the +parquet variant.

adamjstewart · 2023-01-27T16:24:14Z

Need to resolve merge conflicts

Decouple setup_build_environment from install_options

heerener · 2023-02-03T10:31:18Z

I noticed that the licenses were still set to 2022.
@tldahlgren , github tells me you still have one open change request, but I'm not sure what it is / how to mark it as resolved.

thomas-bouvier · 2023-02-07T09:46:26Z

@spackbot run pipeline

tldahlgren

Re-confirmed all affected version sha256.

tldahlgren · 2023-02-16T16:39:36Z

I noticed that the licenses were still set to 2022.
@tldahlgren , github tells me you still have one open change request, but I'm not sure what it is / how to mark it as resolved.

Last I heard Spack may be getting rid of the copyright year so this doesn't have to be changed every year.

Looks like @adamjstewart addressed the change request issue and has since approved the PR.

* Add py-mlflow and its dependencies * mlflow: fix syntax error in package.py * py-mlflow: cleanup Process review remarks, add missing dependencies, add skinny variant * Apply suggestions from code review * Fix flake8 issues * More formatting fixes * Fix py-waitress dependency version * py-mlflow: platform-specific dependency * Update var/spack/repos/builtin/packages/py-mlflow/package.py * Update var/spack/repos/builtin/packages/py-mlflow/package.py * Process review remarks * Fix typo in dependency version * py-shap: fix dependencies * py-arrow: fix dependencies * py-slicer: remove py-setuptools explicit version * py-pyarrow: dataset variant and pass options through environment It appears there are some issues when using `pip install` instead of `python setup.py` - this setup_build_environment should fix that. * py-pyarrow: review remark * Decouple setup_build_environment from install_options * py-pyarrow: style * Bump licenses to 2023 --------- Co-authored-by: Tamara Dahlgren <[email protected]> Co-authored-by: Adam J. Stewart <[email protected]> Co-authored-by: Matthias Wolf <[email protected]>

Add py-mlflow and its dependencies

ac3389d

spackbot-app bot added dependencies new-package new-version python labels Dec 12, 2022

heerener added 2 commits December 12, 2022 14:47

mlflow: fix syntax error in package.py

7764d12

Merge branch 'develop' into add-py-mlflow

35f08ec

tldahlgren requested changes Dec 12, 2022

View reviewed changes

tldahlgren requested a review from adamjstewart December 12, 2022 22:09

tldahlgren self-assigned this Dec 12, 2022

adamjstewart self-assigned this Dec 12, 2022

adamjstewart requested changes Dec 12, 2022

View reviewed changes

py-mlflow: cleanup

a782f78

Process review remarks, add missing dependencies, add skinny variant

spackbot-app bot added new-variant update-package labels Dec 13, 2022

heerener commented Dec 13, 2022

View reviewed changes

var/spack/repos/builtin/packages/py-mlflow/package.py Outdated Show resolved Hide resolved

Apply suggestions from code review

d4613db

Co-authored-by: Tamara Dahlgren <[email protected]> Co-authored-by: Adam J. Stewart <[email protected]>

[@spackbot] updating style on behalf of heerener

6d3e32b

heerener added 4 commits December 13, 2022 15:09

Fix flake8 issues

2a00ce1

More formatting fixes

41c9a39

Fix py-waitress dependency version

cb1f390

py-mlflow: platform-specific dependency

0494691

adamjstewart requested changes Dec 15, 2022

View reviewed changes

heerener and others added 2 commits December 15, 2022 08:44

Update var/spack/repos/builtin/packages/py-mlflow/package.py

778964a

Co-authored-by: Adam J. Stewart <[email protected]>

Update var/spack/repos/builtin/packages/py-mlflow/package.py

97748e5

Co-authored-by: Adam J. Stewart <[email protected]>

adamjstewart requested changes Dec 15, 2022

View reviewed changes

heerener added 3 commits January 3, 2023 09:06

py-shap: fix dependencies

2cca650

py-arrow: fix dependencies

c7fec55

py-slicer: remove py-setuptools explicit version

e261d84

adamjstewart previously approved these changes Jan 3, 2023

View reviewed changes

adamjstewart requested a review from tldahlgren January 3, 2023 18:53

py-pyarrow: dataset variant and pass options through environment

5dfca3d

It appears there are some issues when using `pip install` instead of `python setup.py` - this setup_build_environment should fix that.

heerener dismissed adamjstewart’s stale review via 5dfca3d January 27, 2023 13:21

heerener commented Jan 27, 2023

View reviewed changes

var/spack/repos/builtin/packages/py-pyarrow/package.py Show resolved Hide resolved

thomas-bouvier mentioned this pull request Jan 27, 2023

ModuleNotFoundError for pyarrow.parquet after building py-pyarrow +parquet #35160

Closed

3 tasks

heerener added 3 commits January 30, 2023 08:18

Merge branch 'develop' into add-py-mlflow

7cd1dea

py-pyarrow: review remark

453d195

Decouple setup_build_environment from install_options

py-pyarrow: style

d3c8fc8

adamjstewart previously approved these changes Jan 30, 2023

View reviewed changes

Bump licenses to 2023

19ab7b7

heerener dismissed adamjstewart’s stale review via 19ab7b7 February 3, 2023 10:29

adamjstewart approved these changes Feb 3, 2023

View reviewed changes

tldahlgren approved these changes Feb 16, 2023

View reviewed changes

tldahlgren merged commit bfe06f6 into spack:develop Feb 16, 2023

thomas-bouvier mentioned this pull request Feb 16, 2023

py-pyarrow: add version v10.0.1 #35068

Closed

heerener deleted the add-py-mlflow branch February 17, 2023 08:41

manuelakuhn mentioned this pull request Jul 7, 2023

py-pyarrow: disable dataset variant by default #38775

Merged

Conversation

heerener commented Dec 12, 2022

Uh oh!

spackbot-app bot commented Dec 12, 2022

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tldahlgren commented Dec 12, 2022

Uh oh!

adamjstewart left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

heerener commented Dec 13, 2022

Uh oh!

spackbot-app bot commented Dec 13, 2022

Uh oh!

spackbot-app bot commented Dec 13, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thomas-bouvier commented Jan 27, 2023

Uh oh!

adamjstewart commented Jan 27, 2023

Uh oh!

heerener commented Feb 3, 2023

Uh oh!

thomas-bouvier commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

tldahlgren commented Feb 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thomas-bouvier commented Feb 7, 2023 •

edited

Loading