Do not merge: VTK-m hack for Crusher#34427
Closed
kwryankrattiger wants to merge 2 commits intospack:developfrom
Closed
Do not merge: VTK-m hack for Crusher#34427kwryankrattiger wants to merge 2 commits intospack:developfrom
kwryankrattiger wants to merge 2 commits intospack:developfrom
Conversation
Contributor
Author
|
TODO: Update this with compiler checks to select the paths based on the compiler/MPI. The GTL stuff I think is common to all of the compilers but I need to double check still. This is currently hard-coded for the CCE compiler toolchain on crusher. |
4 tasks
kwryankrattiger
force-pushed
the
crusher_vtkm_hack
branch
from
1fafb3a to
8343778
Compare
Member
|
Is this PR still relevant? |
Contributor
Author
It can probably be closed now, I am going to properly fix this by porting over cray-mpich GTL awareness that was put in awhile ago which should solve this for real. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch for building VTK-m +rocm +mpi on Crusher.
CC: @eugeneswalker