Skip to content

add py-psij-python and py-pystache packages#34357

Merged
adamjstewart merged 19 commits intospack:developfrom
radical-cybertools:feature/psij
Dec 22, 2022
Merged

add py-psij-python and py-pystache packages#34357
adamjstewart merged 19 commits intospack:developfrom
radical-cybertools:feature/psij

Conversation

@andre-merzky
Copy link
Copy Markdown
Contributor

psij-python is a python module which abstracts job submission to batch systems. It is developed in the context of the ExaWorks project. This PR adds a spack package.

@adamjstewart adamjstewart self-assigned this Dec 6, 2022
@andre-merzky andre-merzky self-assigned this Dec 6, 2022
adamjstewart
adamjstewart previously approved these changes Dec 6, 2022
@adamjstewart adamjstewart enabled auto-merge (squash) December 6, 2022 19:55
@tldahlgren tldahlgren changed the title add py-psij-python package add py-psij-python and py-pystache packages Dec 7, 2022
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed both sha256. Would prefer a more user-friendly homepage for pystache.

@tldahlgren tldahlgren self-assigned this Dec 7, 2022
@adamjstewart adamjstewart disabled auto-merge December 7, 2022 18:44
@andre-merzky
Copy link
Copy Markdown
Contributor Author

Confirmed both sha256. Would prefer a more user-friendly homepage for pystache.

I am afraid we don't maintain pystache - that package is only added as dependency.

apply suggested change
@tldahlgren
Copy link
Copy Markdown
Contributor

Confirmed both sha256. Would prefer a more user-friendly homepage for pystache.

I am afraid we don't maintain pystache - that package is only added as dependency.

Understandable. Thanks for the homepage update.

tldahlgren
tldahlgren previously approved these changes Dec 7, 2022
adamjstewart
adamjstewart previously approved these changes Dec 7, 2022
@adamjstewart adamjstewart enabled auto-merge (squash) December 7, 2022 18:58
auto-merge was automatically disabled December 8, 2022 01:23

Head branch was pushed to by a user without write access

@andre-merzky andre-merzky dismissed stale reviews from adamjstewart and tldahlgren via de516b4 December 8, 2022 01:23
@andre-merzky
Copy link
Copy Markdown
Contributor Author

I am sorry for pushing yet another commit to this PR after approval - I forgot to add the new package to the exaworks meta-package :-/

@adamjstewart adamjstewart enabled auto-merge (squash) December 8, 2022 02:05
@andre-merzky
Copy link
Copy Markdown
Contributor Author

@adamjstewart : Hey Adam, I seem to miss something with the merge policy. I tried to read up on the Deferred Pipelines policy, but did that after I synced the branch once already (I assumed back then that the merge stalled because the PR was out of sync with base, which is what usually happens on active projects).

The guide says: Rebasing or merging develop into your PR branch is likely to cause your GitLab CI pipelines to be deferred for a longer period of time. How long is longer period? :-) Is there a way to get this PR unstuck? Should I reopen it?

Thanks for any advise you are able to offer...

@adamjstewart
Copy link
Copy Markdown
Member

Usually 12 to 24 hrs unfortunately. Not sure if @scottwittenburg or @zackgalbreath have any ideas to make this quicker. My suggestion would be to just wait.

@andre-merzky
Copy link
Copy Markdown
Contributor Author

Hmm, the PR hung for about two weeks now, which is what got me worried. If it resolves itself in a couple of days, then that's great. Let me be patient then till after the break, I can ping again if nothing happens :-)

Thanks!

@adamjstewart
Copy link
Copy Markdown
Member

If it hangs again let me know. If you have permissions (you prob don't?) you can rerun individual tests. If you don't, you can close and reopen to rerun all tests or use @spackbot run pipeline to run just the pipeline. Rebasing also works, but now you have to wait 24+ hrs before the pipelines will start to run.

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Dec 20, 2022

I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now.

One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a develop pipeline, and will be run when that finishes.

Please check the gitlab commit status message to see if more information is available.

Details
pr head: a286e8c, gitlab commit parents: ['52fdae8', '1f217a9']

@mtitov
Copy link
Copy Markdown
Contributor

mtitov commented Dec 21, 2022

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Dec 21, 2022

Sorry mtitov, I cannot do that for you. Only users with write can make this request!

@adamjstewart
Copy link
Copy Markdown
Member

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Dec 22, 2022

I've started that pipeline for you!

@adamjstewart adamjstewart merged commit f116e67 into spack:develop Dec 22, 2022
stephenmsachs pushed a commit to stephenmsachs/spack that referenced this pull request Jan 3, 2023
* add psij package and deps

* update hashes, URLs

* linting

* Update var/spack/repos/builtin/packages/py-psij-python/package.py

Co-authored-by: Adam J. Stewart <[email protected]>

* Update var/spack/repos/builtin/packages/py-pystache/package.py

Co-authored-by: Adam J. Stewart <[email protected]>

* Update var/spack/repos/builtin/packages/py-pystache/package.py

Co-authored-by: Tamara Dahlgren <[email protected]>

* Update package.py

apply suggested change

* Update package.py

apply suggested change

* Update package.py

ensure maintainer inheritance

* add psij to exaworks meta-package

Co-authored-by: Adam J. Stewart <[email protected]>
Co-authored-by: Tamara Dahlgren <[email protected]>
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 24, 2023
* add psij package and deps

* update hashes, URLs

* linting

* Update var/spack/repos/builtin/packages/py-psij-python/package.py

Co-authored-by: Adam J. Stewart <[email protected]>

* Update var/spack/repos/builtin/packages/py-pystache/package.py

Co-authored-by: Adam J. Stewart <[email protected]>

* Update var/spack/repos/builtin/packages/py-pystache/package.py

Co-authored-by: Tamara Dahlgren <[email protected]>

* Update package.py

apply suggested change

* Update package.py

apply suggested change

* Update package.py

ensure maintainer inheritance

* add psij to exaworks meta-package

Co-authored-by: Adam J. Stewart <[email protected]>
Co-authored-by: Tamara Dahlgren <[email protected]>
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
* add psij package and deps

* update hashes, URLs

* linting

* Update var/spack/repos/builtin/packages/py-psij-python/package.py

Co-authored-by: Adam J. Stewart <[email protected]>

* Update var/spack/repos/builtin/packages/py-pystache/package.py

Co-authored-by: Adam J. Stewart <[email protected]>

* Update var/spack/repos/builtin/packages/py-pystache/package.py

Co-authored-by: Tamara Dahlgren <[email protected]>

* Update package.py

apply suggested change

* Update package.py

apply suggested change

* Update package.py

ensure maintainer inheritance

* add psij to exaworks meta-package

Co-authored-by: Adam J. Stewart <[email protected]>
Co-authored-by: Tamara Dahlgren <[email protected]>
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
* add psij package and deps

* update hashes, URLs

* linting

* Update var/spack/repos/builtin/packages/py-psij-python/package.py

Co-authored-by: Adam J. Stewart <[email protected]>

* Update var/spack/repos/builtin/packages/py-pystache/package.py

Co-authored-by: Adam J. Stewart <[email protected]>

* Update var/spack/repos/builtin/packages/py-pystache/package.py

Co-authored-by: Tamara Dahlgren <[email protected]>

* Update package.py

apply suggested change

* Update package.py

apply suggested change

* Update package.py

ensure maintainer inheritance

* add psij to exaworks meta-package

Co-authored-by: Adam J. Stewart <[email protected]>
Co-authored-by: Tamara Dahlgren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants