Skip to content

remove legcay yaml from buildcache fetch#34347

Merged
alalazo merged 1 commit intospack:developfrom
haampie:fix/remove-yaml-from-bincache
Dec 6, 2022
Merged

remove legcay yaml from buildcache fetch#34347
alalazo merged 1 commit intospack:developfrom
haampie:fix/remove-yaml-from-bincache

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Dec 6, 2022

This was deprecated in 0.19.0, so it can be removed.

Reduces the number of 404s by a third on miss

@spackbot-app spackbot-app bot added binary-packages core PR affects Spack core functionality tests General test capability(ies) labels Dec 6, 2022
@haampie haampie requested a review from alalazo December 6, 2022 10:45
Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alalazo alalazo merged commit b58ec9e into spack:develop Dec 6, 2022
@haampie haampie deleted the fix/remove-yaml-from-bincache branch December 6, 2022 16:08
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
MatthewLieber added a commit to OSU-Nowlab/spack that referenced this pull request Mar 20, 2023
MatthewLieber added a commit to OSU-Nowlab/spack that referenced this pull request Mar 20, 2023
tldahlgren pushed a commit that referenced this pull request Mar 22, 2023
* Revert "Remove legacy yaml from buildcache fetch (#34347)"
  This reverts commit b58ec9e.
* Revert "Revert "Remove legacy yaml from buildcache fetch (#34347)""
  This reverts commit f91ec2e.
* add variant for hwloc v2
* running black

---------

Co-authored-by: Matt Lieber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binary-packages core PR affects Spack core functionality tests General test capability(ies)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants