Avoid stat call in llnl.util.symlink on non-windows#34321
Merged
scheibelp merged 3 commits intospack:developfrom Dec 6, 2022
Merged
Avoid stat call in llnl.util.symlink on non-windows#34321scheibelp merged 3 commits intospack:developfrom
llnl.util.symlink on non-windows#34321scheibelp merged 3 commits intospack:developfrom
Conversation
haampie
requested review from
johnwparent and
scheibelp
and removed request for
johnwparent
haampie
changed the title
haampie
changed the title
llnl.util.symlink on non-windows
scheibelp
approved these changes
Dec 5, 2022
Member
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid the redundant stat call on non-windows introduced in #33021
When creating environment views etc we really don't want to double the stat calls.