vermin: remove all novm comments from code#34308
Merged
Conversation
spackbot-app
bot
added
build-systems
commands
compilers
core
Member
|
Duplicate of #34119 |
tgamblin
force-pushed
the
remove-novm-annotations
branch
from
3175a21 to
16afb1e
Compare
Member
Author
All the vermin annotations we were using were for optional features introduced in early Python 3 versions. We no longer need any of them, as we only support Python 3.6+. If we start optionally using features from newer Pythons than 3.6, we will need more vermin annotations. Co-authored-by: Harmen Stoppels <[email protected]>
tgamblin
force-pushed
the
remove-novm-annotations
branch
from
16afb1e to
9d86cbc
Compare
alalazo
approved these changes
Dec 5, 2022
adamjstewart
approved these changes
Dec 5, 2022
Member
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
luke-dt
pushed a commit
to dantaslab/spack
that referenced
this pull request
Dec 5, 2022
All the vermin annotations we were using were for optional features introduced in early Python 3 versions. We no longer need any of them, as we only support Python 3.6+. If we start optionally using features from newer Pythons than 3.6, we will need more vermin annotations. Co-authored-by: Harmen Stoppels <[email protected]> Co-authored-by: Harmen Stoppels <[email protected]>
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
All the vermin annotations we were using were for optional features introduced in early Python 3 versions. We no longer need any of them, as we only support Python 3.6+. If we start optionally using features from newer Pythons than 3.6, we will need more vermin annotations. Co-authored-by: Harmen Stoppels <[email protected]> Co-authored-by: Harmen Stoppels <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of our vermin
#novmannotations are for optional features introduced in early Python 3 versions. We no longer need any of them, as we only support Python 3.6+. If we start optionally using features from newer Pythons than 3.6, we will need more vermin annotations.