typing: move from comment type hints to Python 3.6 hints#34305
Merged
typing: move from comment type hints to Python 3.6 hints#34305
Conversation
spackbot-app
bot
added
architecture
build-environment
build-systems
commands
compilers
core
adamjstewart
previously approved these changes
Dec 4, 2022
Member
Author
|
Sigh. TIL about Python 3.6.15 (default, Dec 21 2021, 08:03:21)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import re
>>> re.match("foo", "foo")
<_sre.SRE_Match object; span=(0, 3), match='foo'>Python 3.7.15 (default, Nov 15 2022, 10:33:03)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import re
>>> re.match("foo", "foo")
<re.Match object; span=(0, 3), match='foo'>So you have to use |
adamjstewart
previously approved these changes
Dec 4, 2022
Member
|
Are we running the style tests on multiple versions of Python? I think we only need to test on the latest version. |
adamjstewart
previously approved these changes
Dec 4, 2022
adamjstewart
reviewed
Dec 4, 2022
Member
Author
When you use the real type hints, things can fail in older versions even if we do not run the style checks. e.g.: import re
from typing import List, Tuple
def __init__(self, all_unquoted_flag_pairs: List[Tuple[re.Match, str]]):
...
import re
from typing import List, Match, Tuple
def __init__(self, all_unquoted_flag_pairs: List[Tuple[Match[str], str]]):
... |
tgamblin
changed the title
We've stopped supporting Python 2, and contributors are noticing that our CI no longer allows Python 2.7 comment type hints. They end up having to adapt them, but this adds extra unrelated work to PRs. - [x] Move to 3.6 type hints across the entire code base
adamjstewart
approved these changes
Dec 5, 2022
Member
|
Gotcha. There's also: from __future__ import annotationsbut I've been avoiding that because of https://docs.python.org/3/library/__future__.html#id2. |
Member
Author
|
Sadly looks like we cannot have that until 3.7 |
luke-dt
pushed a commit
to dantaslab/spack
that referenced
this pull request
Dec 5, 2022
…k#34305) We've stopped supporting Python 2, and contributors are noticing that our CI no longer allows Python 2.7 comment type hints. They end up having to adapt them, but this adds extra unrelated work to PRs. - [x] Move to 3.6 type hints across the entire code base
tgamblin
added a commit
that referenced
this pull request
Dec 23, 2022
Apparently I forgot to do this in #34305.
tgamblin
added a commit
that referenced
this pull request
Dec 23, 2022
Apparently I forgot to do this in #34305.
haampie
pushed a commit
that referenced
this pull request
Dec 26, 2022
Apparently I forgot to do this in #34305.
stephenmsachs
pushed a commit
to stephenmsachs/spack
that referenced
this pull request
Jan 3, 2023
Apparently I forgot to do this in spack#34305.
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 24, 2023
Apparently I forgot to do this in spack#34305.
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
…k#34305) We've stopped supporting Python 2, and contributors are noticing that our CI no longer allows Python 2.7 comment type hints. They end up having to adapt them, but this adds extra unrelated work to PRs. - [x] Move to 3.6 type hints across the entire code base
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
Apparently I forgot to do this in spack#34305.
techxdave
pushed a commit
to Tech-XCorp/spack
that referenced
this pull request
Feb 17, 2023
Apparently I forgot to do this in spack#34305.
jmcarcell
pushed a commit
to key4hep/spack
that referenced
this pull request
Apr 13, 2023
Apparently I forgot to do this in spack#34305.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've stopped supporting Python 2, and contributors are noticing that our CI no longer allows Python 2.7 comment type hints. They end up having to adapt them, but this adds extra unrelated work to PRs.