doxygen: add build-tools tag#34249
Conversation
This allows it to be included automatically as an external. No one links against doxygen so this should be ok.
|
Hi @sethrj! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers = ["sethrj"]If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame doxygenThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
|
|
||
| variant("mscgen", default=False, description="Build with support for code graphs from mscgen.") | ||
|
|
||
| tags = ["build-tools"] |
There was a problem hiding this comment.
Nit: Is it a build or documentation tool?
I can understand why someone would want to flag the package as a build tool for query purposes so I'll approve as is.
There was a problem hiding this comment.
There is no doc-tools tag, and usually documentation tools are build tools since they're used as executables to generate documentation at build time.
There was a problem hiding this comment.
I noticed there are no doc-related tags. You could start one if you want 😉 .
Fair point about how it fits in workflows.
|
Thanks for the review @tldahlgren ! |
* doxygen: add build-tool tag This allows it to be included automatically as an external. No one links against doxygen so this should be ok. * doxygen: add self as maintainer
* doxygen: add build-tool tag This allows it to be included automatically as an external. No one links against doxygen so this should be ok. * doxygen: add self as maintainer
2 participants
This allows it to be included automatically as an external. No one links against doxygen so this should be ok.