ROOT: add math/gsl conflict and change version-dependent features to conditional variants#34244
Merged
tldahlgren merged 4 commits intospack:developfrom Dec 2, 2022
Merged
Conversation
spackbot-app
bot
requested review from
HadrienG2,
drbenmorgan,
greenc-FNAL and
vvolkl
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, mypy, black, flake8
==> Modified files
var/spack/repos/builtin/packages/root/package.py
==> Running isort checks
isort checks were clean
==> Running mypy checks
lib/spack/llnl/util/lock.py:83: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
lib/spack/llnl/util/lang.py:1048: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
lib/spack/spack/bootstrap.py:89: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
Success: no issues found in 558 source files
mypy checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/root/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
Member
|
I think this is fine, and along the same lines as #34185 though addressing different variants. So I'm fine with the changes here, though @HadrienG2 and @vvolkl should have final say! |
HadrienG2
approved these changes
Dec 1, 2022
Contributor
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
luke-dt
pushed a commit
to dantaslab/spack
that referenced
this pull request
Dec 5, 2022
…conditional variants (spack#34244) * ROOT: add GSL/math dependency * ROOT: use conditional variants instead of conflicts
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
…conditional variants (spack#34244) * ROOT: add GSL/math dependency * ROOT: use conditional variants instead of conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.