Merged
Conversation
Contributor
|
Yes @drbenmorgan please add a conflict to document that 😊 |
Recent tests of vecgeom in Spack environments have shown that the build with +cuda fails with GCC >= 11.3 and CUDA < 11.7 with error ...lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/serializeintrin.h(41): error: identifier "__builtin_ia32_serialize" is undefined 1 error detected in the compilation of ".../VecGeom/source/BVHManager.cu". Other GCC/CUDA combinations appear o.k. Avoid this error in spack, and document it for users, with a conflict directive to express the restriction.
Contributor
|
@spackbot help |
|
You can interact with me in many ways!
I'll also help to label your pull request and assign reviewers! |
Contributor
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
Member
Author
|
Oh, that's new to me - very nice! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, mypy, black, flake8
==> Modified files
var/spack/repos/builtin/packages/vecgeom/package.py
==> Bootstrapping py-black from pre-built binaries
==> Bootstrapping py-black from pre-built binaries
==> Bootstrapping py-black %gcc target=x86_64 from sources
==> Bootstrapping clingo from pre-built binaries
==> Fetching https://mirror.spack.io/bootstrap/github-actions/v0.4/build_cache/linux-centos7-x86_64-gcc-10.2.1-clingo-bootstrap-spack-axtxtavfahxuazw2wueu3tjwwu6ttdfo.spec.json
==> Fetching https://mirror.spack.io/bootstrap/github-actions/v0.4/build_cache/linux-centos7-x86_64/gcc-10.2.1/clingo-bootstrap-spack/linux-centos7-x86_64-gcc-10.2.1-clingo-bootstrap-spack-axtxtavfahxuazw2wueu3tjwwu6ttdfo.spack
==> Installing "clingo-bootstrap@spack%[email protected]~docs~ipo+python+static_libstdcpp build_type=Release arch=linux-centos7-x86_64" from a buildcache
[+] /usr/local (external python-3.7-ghm47tmhike6qomrerkdjbxkqsnintxs)
==> Waiting for py-pip-22.2.2-qz4syayp5sd4f4npyu6pq4foj7ifp4ef
�[1F�[J==> Installing py-pip-22.2.2-qz4syayp5sd4f4npyu6pq4foj7ifp4ef
==> No binary for py-pip-22.2.2-qz4syayp5sd4f4npyu6pq4foj7ifp4ef found: installing from source
==> Fetching https://files.pythonhosted.org/packages/py3/p/pip/pip-22.2.2-py3-none-any.whl
==> No patches needed for py-pip
==> py-pip: Executing phase: 'install'
==> py-pip: Successfully installed py-pip-22.2.2-qz4syayp5sd4f4npyu6pq4foj7ifp4ef
Stage: 0.74s. Install: 4.77s. Total: 5.56s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-pip-22.2.2-qz4syayp5sd4f4npyu6pq4foj7ifp4ef
==> Waiting for py-setuptools-65.5.0-uegp2rqlyliofx3wdrtkgb4ymgsnnyad
�[1F�[J==> Installing py-setuptools-65.5.0-uegp2rqlyliofx3wdrtkgb4ymgsnnyad
==> No binary for py-setuptools-65.5.0-uegp2rqlyliofx3wdrtkgb4ymgsnnyad found: installing from source
==> Fetching https://files.pythonhosted.org/packages/py3/s/setuptools/setuptools-65.5.0-py3-none-any.whl
==> No patches needed for py-setuptools
==> py-setuptools: Executing phase: 'install'
==> py-setuptools: Successfully installed py-setuptools-65.5.0-uegp2rqlyliofx3wdrtkgb4ymgsnnyad
Stage: 0.70s. Install: 1.30s. Total: 2.06s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-setuptools-65.5.0-uegp2rqlyliofx3wdrtkgb4ymgsnnyad
==> Waiting for py-wheel-0.37.1-b2biuznswbfidiye54zzfwf6oen4rtqm
�[1F�[J==> Installing py-wheel-0.37.1-b2biuznswbfidiye54zzfwf6oen4rtqm
==> No binary for py-wheel-0.37.1-b2biuznswbfidiye54zzfwf6oen4rtqm found: installing from source
==> Fetching https://files.pythonhosted.org/packages/py2.py3/w/wheel/wheel-0.37.1-py2.py3-none-any.whl
==> No patches needed for py-wheel
==> py-wheel: Executing phase: 'install'
==> py-wheel: Successfully installed py-wheel-0.37.1-b2biuznswbfidiye54zzfwf6oen4rtqm
Stage: 0.67s. Install: 0.87s. Total: 1.61s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-wheel-0.37.1-b2biuznswbfidiye54zzfwf6oen4rtqm
==> Waiting for py-typed-ast-1.5.4-gbcinlsculcobeo3ebzz3n5pcfo7juxe
�[1F�[J==> Installing py-typed-ast-1.5.4-gbcinlsculcobeo3ebzz3n5pcfo7juxe
==> No binary for py-typed-ast-1.5.4-gbcinlsculcobeo3ebzz3n5pcfo7juxe found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/t/typed-ast/typed_ast-1.5.4.tar.gz
==> No patches needed for py-typed-ast
==> py-typed-ast: Executing phase: 'install'
==> py-typed-ast: Successfully installed py-typed-ast-1.5.4-gbcinlsculcobeo3ebzz3n5pcfo7juxe
Stage: 0.81s. Install: 15.39s. Total: 16.28s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-typed-ast-1.5.4-gbcinlsculcobeo3ebzz3n5pcfo7juxe
==> Waiting for py-flit-core-3.7.1-ooquxroaqn4mtf2hedbrdwdd6st77ckw
�[1F�[J==> Installing py-flit-core-3.7.1-ooquxroaqn4mtf2hedbrdwdd6st77ckw
==> No binary for py-flit-core-3.7.1-ooquxroaqn4mtf2hedbrdwdd6st77ckw found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/f/flit-core/flit_core-3.7.1.tar.gz
==> No patches needed for py-flit-core
==> py-flit-core: Executing phase: 'install'
==> py-flit-core: Successfully installed py-flit-core-3.7.1-ooquxroaqn4mtf2hedbrdwdd6st77ckw
Stage: 0.82s. Install: 1.38s. Total: 2.26s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-flit-core-3.7.1-ooquxroaqn4mtf2hedbrdwdd6st77ckw
==> Waiting for py-pathspec-0.10.1-ppupz3dpso4jouub6uvlmtsuydoj6piv
�[1F�[J==> Installing py-pathspec-0.10.1-ppupz3dpso4jouub6uvlmtsuydoj6piv
==> No binary for py-pathspec-0.10.1-ppupz3dpso4jouub6uvlmtsuydoj6piv found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/p/pathspec/pathspec-0.10.1.tar.gz
==> No patches needed for py-pathspec
==> py-pathspec: Executing phase: 'install'
==> py-pathspec: Successfully installed py-pathspec-0.10.1-ppupz3dpso4jouub6uvlmtsuydoj6piv
Stage: 0.71s. Install: 1.99s. Total: 2.78s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-pathspec-0.10.1-ppupz3dpso4jouub6uvlmtsuydoj6piv
==> Waiting for py-mypy-extensions-0.4.3-e5qx74l6i2z4sdtgko2qk5zgblbdyrlt
�[1F�[J==> Installing py-mypy-extensions-0.4.3-e5qx74l6i2z4sdtgko2qk5zgblbdyrlt
==> No binary for py-mypy-extensions-0.4.3-e5qx74l6i2z4sdtgko2qk5zgblbdyrlt found: installing from source
==> Fetching https://mirror.spack.io/_source-cache/archive/2d/2d82818f5bb3e369420cb3c4060a7970edba416647068eb4c5343488a6c604a8.tar.gz
==> No patches needed for py-mypy-extensions
==> py-mypy-extensions: Executing phase: 'install'
==> py-mypy-extensions: Successfully installed py-mypy-extensions-0.4.3-e5qx74l6i2z4sdtgko2qk5zgblbdyrlt
Stage: 0.07s. Install: 1.31s. Total: 1.45s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-mypy-extensions-0.4.3-e5qx74l6i2z4sdtgko2qk5zgblbdyrlt
==> Waiting for py-pyparsing-3.0.9-4b4efvyt6osianudmb56eacdn6cro565
�[1F�[J==> Installing py-pyparsing-3.0.9-4b4efvyt6osianudmb56eacdn6cro565
==> No binary for py-pyparsing-3.0.9-4b4efvyt6osianudmb56eacdn6cro565 found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/p/pyparsing/pyparsing-3.0.9.tar.gz
==> No patches needed for py-pyparsing
==> py-pyparsing: Executing phase: 'install'
==> py-pyparsing: Successfully installed py-pyparsing-3.0.9-4b4efvyt6osianudmb56eacdn6cro565
Stage: 0.83s. Install: 0.94s. Total: 1.82s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-pyparsing-3.0.9-4b4efvyt6osianudmb56eacdn6cro565
==> Waiting for py-tomli-2.0.1-4fprnymiem3eff3xchgz3fcmtun5b2ep
�[1F�[J==> Installing py-tomli-2.0.1-4fprnymiem3eff3xchgz3fcmtun5b2ep
==> No binary for py-tomli-2.0.1-4fprnymiem3eff3xchgz3fcmtun5b2ep found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/t/tomli/tomli-2.0.1.tar.gz
==> No patches needed for py-tomli
==> py-tomli: Executing phase: 'install'
==> py-tomli: Successfully installed py-tomli-2.0.1-4fprnymiem3eff3xchgz3fcmtun5b2ep
Stage: 0.77s. Install: 0.85s. Total: 1.69s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-tomli-2.0.1-4fprnymiem3eff3xchgz3fcmtun5b2ep
==> Waiting for py-typing-extensions-4.3.0-kah3aimirlmbm46vlxhkbmrjpojit6by
�[1F�[J==> Installing py-typing-extensions-4.3.0-kah3aimirlmbm46vlxhkbmrjpojit6by
==> No binary for py-typing-extensions-4.3.0-kah3aimirlmbm46vlxhkbmrjpojit6by found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/t/typing_extensions/typing_extensions-4.3.0.tar.gz
==> No patches needed for py-typing-extensions
==> py-typing-extensions: Executing phase: 'install'
==> py-typing-extensions: Successfully installed py-typing-extensions-4.3.0-kah3aimirlmbm46vlxhkbmrjpojit6by
Stage: 0.75s. Install: 0.78s. Total: 1.58s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-typing-extensions-4.3.0-kah3aimirlmbm46vlxhkbmrjpojit6by
==> Waiting for py-packaging-21.3-zxsmui6q2fagdkvgrbr3b46mummy34xs
�[1F�[J==> Installing py-packaging-21.3-zxsmui6q2fagdkvgrbr3b46mummy34xs
==> No binary for py-packaging-21.3-zxsmui6q2fagdkvgrbr3b46mummy34xs found: installing from source
==> Fetching https://mirror.spack.io/_source-cache/archive/dd/dd47c42927d89ab911e606518907cc2d3a1f38bbd026385970643f9c5b8ecfeb.tar.gz
==> No patches needed for py-packaging
==> py-packaging: Executing phase: 'install'
==> py-packaging: Successfully installed py-packaging-21.3-zxsmui6q2fagdkvgrbr3b46mummy34xs
Stage: 0.12s. Install: 1.90s. Total: 2.10s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-packaging-21.3-zxsmui6q2fagdkvgrbr3b46mummy34xs
==> Waiting for py-setuptools-scm-6.3.2-d7coq3znhfua2lzvmct36igh5hghdsgs
�[1F�[J==> Installing py-setuptools-scm-6.3.2-d7coq3znhfua2lzvmct36igh5hghdsgs
==> No binary for py-setuptools-scm-6.3.2-d7coq3znhfua2lzvmct36igh5hghdsgs found: installing from source
==> Fetching https://mirror.spack.io/_source-cache/archive/a4/a49aa8081eeb3514eb9728fa5040f2eaa962d6c6f4ec9c32f6c1fba88f88a0f2.tar.gz
==> No patches needed for py-setuptools-scm
==> py-setuptools-scm: Executing phase: 'install'
==> py-setuptools-scm: Successfully installed py-setuptools-scm-6.3.2-d7coq3znhfua2lzvmct36igh5hghdsgs
Stage: 0.09s. Install: 1.58s. Total: 1.74s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-setuptools-scm-6.3.2-d7coq3znhfua2lzvmct36igh5hghdsgs
==> Waiting for py-platformdirs-2.4.1-i6ii4vmzq5qfjftkn2wnz4zety5yzyur
�[1F�[J==> Installing py-platformdirs-2.4.1-i6ii4vmzq5qfjftkn2wnz4zety5yzyur
==> No binary for py-platformdirs-2.4.1-i6ii4vmzq5qfjftkn2wnz4zety5yzyur found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/p/platformdirs/platformdirs-2.4.1.tar.gz
==> No patches needed for py-platformdirs
==> py-platformdirs: Executing phase: 'install'
==> py-platformdirs: Successfully installed py-platformdirs-2.4.1-i6ii4vmzq5qfjftkn2wnz4zety5yzyur
Stage: 0.76s. Install: 2.45s. Total: 3.29s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-platformdirs-2.4.1-i6ii4vmzq5qfjftkn2wnz4zety5yzyur
==> Waiting for py-zipp-3.8.1-m4auq6iu54iwhllhf3omusnfbschody3
�[1F�[J==> Installing py-zipp-3.8.1-m4auq6iu54iwhllhf3omusnfbschody3
==> No binary for py-zipp-3.8.1-m4auq6iu54iwhllhf3omusnfbschody3 found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/z/zipp/zipp-3.8.1.tar.gz
==> No patches needed for py-zipp
==> py-zipp: Executing phase: 'install'
==> py-zipp: Successfully installed py-zipp-3.8.1-m4auq6iu54iwhllhf3omusnfbschody3
Stage: 0.90s. Install: 4.26s. Total: 5.29s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-zipp-3.8.1-m4auq6iu54iwhllhf3omusnfbschody3
==> Waiting for py-importlib-metadata-4.12.0-5wywku642vzpjc6tcd6srclllnq2wmpu
�[1F�[J==> Installing py-importlib-metadata-4.12.0-5wywku642vzpjc6tcd6srclllnq2wmpu
==> No binary for py-importlib-metadata-4.12.0-5wywku642vzpjc6tcd6srclllnq2wmpu found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/i/importlib_metadata/importlib_metadata-4.12.0.tar.gz
==> No patches needed for py-importlib-metadata
==> py-importlib-metadata: Executing phase: 'install'
==> py-importlib-metadata: Successfully installed py-importlib-metadata-4.12.0-5wywku642vzpjc6tcd6srclllnq2wmpu
Stage: 0.85s. Install: 2.25s. Total: 3.20s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-importlib-metadata-4.12.0-5wywku642vzpjc6tcd6srclllnq2wmpu
==> Waiting for py-click-8.1.3-ckl3p4mqxswzepgxa62yu62rmcunue7t
�[1F�[J==> Installing py-click-8.1.3-ckl3p4mqxswzepgxa62yu62rmcunue7t
==> No binary for py-click-8.1.3-ckl3p4mqxswzepgxa62yu62rmcunue7t found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/c/click/click-8.1.3.tar.gz
==> No patches needed for py-click
==> py-click: Executing phase: 'install'
==> py-click: Successfully installed py-click-8.1.3-ckl3p4mqxswzepgxa62yu62rmcunue7t
Stage: 0.75s. Install: 1.70s. Total: 2.54s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-click-8.1.3-ckl3p4mqxswzepgxa62yu62rmcunue7t
==> Waiting for py-black-22.8.0-4ctg4sinktkqwzarhdibtvdffefhuq2p
�[1F�[J==> Installing py-black-22.8.0-4ctg4sinktkqwzarhdibtvdffefhuq2p
==> No binary for py-black-22.8.0-4ctg4sinktkqwzarhdibtvdffefhuq2p found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/b/black/black-22.8.0.tar.gz
==> No patches needed for py-black
==> py-black: Executing phase: 'install'
==> py-black: Successfully installed py-black-22.8.0-4ctg4sinktkqwzarhdibtvdffefhuq2p
Stage: 0.85s. Install: 2.35s. Total: 3.34s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-black-22.8.0-4ctg4sinktkqwzarhdibtvdffefhuq2p
==> Running isort checks
isort checks were clean
==> Running mypy checks
lib/spack/llnl/util/lang.py:1064: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
lib/spack/spack/util/timer.py:68: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
lib/spack/spack/bootstrap.py:87: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
lib/spack/spack/build_environment.py:290: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
Success: no issues found in 566 source files
mypy checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/vecgeom/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
sethrj
approved these changes
Dec 1, 2022
Contributor
|
One thing to put here for the record is that the |
tldahlgren
approved these changes
Dec 1, 2022
Contributor
tldahlgren
left a comment
There was a problem hiding this comment.
Confirmed sha256, conflict LGTM too
luke-dt
pushed a commit
to dantaslab/spack
that referenced
this pull request
Dec 5, 2022
* vecgeom: add new 1.2.1 version * vecgeom: introduce conflict between gcc/cuda Recent tests of vecgeom in Spack environments have shown that the build with +cuda fails with GCC >= 11.3 and CUDA < 11.7 with error ...lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/serializeintrin.h(41): error: identifier "__builtin_ia32_serialize" is undefined 1 error detected in the compilation of ".../VecGeom/source/BVHManager.cu". Other GCC/CUDA combinations appear o.k. Avoid this error in spack, and document it for users, with a conflict directive to express the restriction.
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
* vecgeom: add new 1.2.1 version * vecgeom: introduce conflict between gcc/cuda Recent tests of vecgeom in Spack environments have shown that the build with +cuda fails with GCC >= 11.3 and CUDA < 11.7 with error ...lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/serializeintrin.h(41): error: identifier "__builtin_ia32_serialize" is undefined 1 error detected in the compilation of ".../VecGeom/source/BVHManager.cu". Other GCC/CUDA combinations appear o.k. Avoid this error in spack, and document it for users, with a conflict directive to express the restriction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the just released patch version 1.2.1, which will also be the required minimum for the upcoming Geant4 minor release.
@sethrj, as we noted elsewhere, this, and earlier versions (at least 1.1.18-1.1.20) do not build with GCC 11.3 and CUDA >=11.6 (GCC 11.2 and compatible CUDAs works though!). Should we use a
conflictto express this?