Stand-alone testing: Make recipe support and processing spack-/pytest-like#34236
Merged
alalazo merged 68 commits intospack:developfrom May 10, 2023
Merged
Stand-alone testing: Make recipe support and processing spack-/pytest-like#34236alalazo merged 68 commits intospack:developfrom
alalazo merged 68 commits intospack:developfrom
Conversation
5acbd36 to
f3f1cc0
Compare
818181d to
c60dbfd
Compare
7fb0118 to
97c7cbf
Compare
4 tasks
9053342 to
486fc0d
Compare
d6d8278 to
f25ef38
Compare
This was referenced Feb 3, 2023
alalazo
approved these changes
May 10, 2023
Member
alalazo
left a comment
There was a problem hiding this comment.
I think we are ready to merge this one. We can keep a close eye on issues that may arise in the forthcoming days, in case we need some minor fixup to follow. For the record I just tested openmpi with both the current setup and with #35802 and it works correctly.
Contributor
Author
Great! I'm inclined to start working on the follow-on test PRs (i.e., confirming they work and making adjustments as needed). |
1 task
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #35519
This PR is a refactor of Spack's stand-alone test process to be more spack- and pytest-like. It is more spack-like in that test parts are no longer "hidden" in a package's
run_test()method and pytest-like in that any package method whose name startstest_(i.e., a "test" method) is a test part. We also support the ability to embed test parts in a test method when that makes sense.Test methods are now implicit test parts. The docstring is the purpose for the test part. The name of the method is the name of the test part. The working directory is the active spec's test stage directory. You can embed test parts using the
test_partcontext manager.This PR adds other functionality (in part because it was originally tested here).
PR highlights:
test_*stand-alone package test methods, each of which is an implicittest_partfor execution and reporting purposes;run_test();run_test()as optional helper methods;SkipTestexception that can be used to flag stand-alone tests as being skipped;