@alalazo @trws What fun! flake8 doesn't like the typing imports:

==> Error: spack style found errors
[30](https://github.com/spack/spack/actions/runs/3587158973/jobs/6037191189#step:6:31)
lib/spack/spack/fetch_strategy.py:33: [F401] 'typing.List' imported but unused
[31](https://github.com/spack/spack/actions/runs/3587158973/jobs/6037191189#step:6:32)
lib/spack/spack/fetch_strategy.py:33: [F401] 'typing.Optional' imported but unused

Thankfully now that we don't have to deal with ancient, pre-typing, python those are a pretty easy fix. Make the type-hint a type-hint rather than a comment and it should pass.

@alalazo @trws Looks like project coverage dropped due to "indirect coverage changes".

I don't think coverage is essential here. What we may have dropped are just the lines in self.curl, or am I missing anything?

I don't think coverage is essential here. What we may have dropped are just the lines in self.curl, or am I missing anything?

I don't think you missed anything. The value for that arg defaults to None is not provided so I just dropped it.

I suppose I could add a test of that method -- preferably mocking which -- to see if that helps with coverage. Although I didn't look closely at all of the indirect coverage changes (once I was able to see them), I didn't quite follow how dropping that method call mattered.

2 for mypy and one for the bug! (Thanks Tammy!)

I grep'd for places where curl is used and, AFAICT, the rest were gated by the configuration parameter. So yes, a one line fix as you'd pointed out.

@spackbot run pipeline

I've started that pipeline for you!

@spackbot run pipeline

I've started that pipeline for you!

@alalazo Thank you!