Skip to content

Add conflicts between [email protected] and [email protected]:5.2.3#34217

Merged
msimberg merged 2 commits intospack:developfrom
aurianer:add_conflict_gcc12
Dec 5, 2022
Merged

Add conflicts between [email protected] and [email protected]:5.2.3#34217
msimberg merged 2 commits intospack:developfrom
aurianer:add_conflict_gcc12

Conversation

@aurianer
Copy link
Copy Markdown
Contributor

@aurianer aurianer commented Nov 30, 2022

Fails with error:

include/c++/12.2.0/bits/shared_ptr_base.h:196:22: error: use of undeclared identifier 'noinline'; did you mean 'inline'?
     1456          __attribute__((__noinline__))
     1457                         ^
include/hip/amd_detail/host_defines.h:50:37: note: expanded from macro '__noinline__'
     1459    #define __noinline__ __attribute__((noinline))
     1460                                        ^

@aurianer aurianer changed the title Add conflicts between [email protected] and [email protected]:5.2.3 Add conflicts between [email protected] and [email protected]:5.2.3 Nov 30, 2022
msimberg
msimberg requested changes Nov 30, 2022
View reviewed changes
@aurianer aurianer changed the title Add conflicts between [email protected] and [email protected]:5.2.3 Add conflicts between [email protected] and [email protected]:5.2.3 Nov 30, 2022
cgmb
cgmb reviewed Nov 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@cgmb cgmb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the incompatibility is between HIP and libstdc++, why are we putting the conflict directive in rocBLAS? I suppose it's rare for it to matter because few libraries use the broken __noinline__? EDIT: I see this was already addressed in another comment.

@msimberg
Copy link
Copy Markdown
Contributor

msimberg commented Nov 30, 2022

If the incompatibility is between HIP and libstdc++, why are we putting the conflict directive in rocBLAS? I suppose it's rare for it to matter because few libraries use the broken __noinline__?

Only because it happens to be triggered while building rocblas but if you see #34217 (comment) we could also just make it a conflict for base HIP itself (in which case it should be for all versions less than 5.3). In theory one can use GCC 12 with the problematic versions as long as one doesn't include <memory> in the wrong place... I'm fine with either approach.

cgmb
cgmb approved these changes Nov 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@cgmb cgmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinions about whether this should be in HIP or rocBLAS. So, I'm fine with this proposal.

@msimberg msimberg merged commit 895ac26 into spack:develop Dec 5, 2022
luke-dt pushed a commit to dantaslab/spack that referenced this pull request Dec 5, 2022
@aurianer @luke-dt
Add conflicts between [email protected] and [email protected]:5.2.3 (spack#34217)
42a84d0 
* Add conflicts with [email protected]

* Add more links for reference
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
@aurianer
Add conflicts between [email protected] and [email protected]:5.2.3 (spack#34217)
f05325d 
* Add conflicts with [email protected]

* Add more links for reference
@aurianer aurianer deleted the add_conflict_gcc12 branch July 4, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msimberg msimberg msimberg approved these changes

@haampie haampie Awaiting requested review from haampie

@renjithravindrankannath renjithravindrankannath Awaiting requested review from renjithravindrankannath

@srekolam srekolam Awaiting requested review from srekolam

+1 more reviewer

@cgmb cgmb cgmb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@msimberg msimberg

@cgmb cgmb

Labels

conflicts update-package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aurianer @msimberg @cgmb