cmake fails with icpc warning#34167
Closed
stephenmsachs wants to merge 118 commits intospack:developfrom
Closed
Conversation
The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs warning spack#2196: routine is both "inline" and "noinline" cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference.
Closed
4 tasks
alalazo
reviewed
Dec 21, 2022
Comment on lines
+315
to
+320
| # The Intel compiler isn't able to deal with noinline member functions of | ||
| # template classses defined in headers. As such it outputs | ||
| # warning #2196: routine is both "inline" and "noinline" | ||
| # cmake bootstrap will fail due to th word 'warning'. | ||
| if spec.satisfies("%intel@:2021.6.0"): | ||
| args.append("CXXFLAGS=-diag-disable=2196") |
Member
There was a problem hiding this comment.
Suggested change
| # The Intel compiler isn't able to deal with noinline member functions of | |
| # template classses defined in headers. As such it outputs | |
| # warning #2196: routine is both "inline" and "noinline" | |
| # cmake bootstrap will fail due to th word 'warning'. | |
| if spec.satisfies("%intel@:2021.6.0"): | |
| args.append("CXXFLAGS=-diag-disable=2196") | |
| # The Intel compiler isn't able to deal with noinline member functions of | |
| # template classes defined in headers. As such it outputs | |
| # warning #2196: routine is both "inline" and "noinline" | |
| # cmake bootstrap will fail due to the word 'warning'. | |
| if spec.satisfies("%intel@:2021.6.0"): | |
| args.append("CXXFLAGS=-diag-disable=2196") |
Pinging @rscohn2 to confirm that's the best way to solve this
Member
There was a problem hiding this comment.
It seems ok. What about icc 2021.7.0, 2021.7.1, & 2021.8.0? They don't have the problem?
Contributor
Author
There was a problem hiding this comment.
No, they don't issue this warning anymore:
$~: compiler=/shared/spack/opt/spack/linux-amzn2-x86_64_v3/gcc-12.2.0/intel-oneapi-compilers-2022.2.0-uqvb2553zy5toeapvoopacndd27x6p5m/compiler/2022.2.0/linux/bin/intel64/icpc
$~: $compiler unique.c
icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
Implement an alternative strategy to do index.json invalidation. The current approach of pairs of index.json / index.json.hash is problematic because it leads to races. The standard solution for cache invalidation is etags, which are supported by both http and s3 protocols, which allows one to do conditional fetches. This PR implements that for the http/https schemes. It should also work for s3 schemes, but that requires other prs to be merged. Also it improves unit tests for index.json fetches.
Replace the filter_file for older configure with rocm 5.3 with an upstream patch. Further, the patch is no longer needed for develop or later releases.
The sticky property will prevent clingo from changing the amdgpu_target to work around conflicts. This is the same behaviour as was adopted for cuda_arch in 055c9d1.
without this patch, build of paraview has a meltdown when reaching 3rd party catalyst and other packages
with these types of errors:
335 /tmp/foo/spack-stage/spack-stage-paraview-5.10.1-gscoqxhhakjyyfirdefuhmi2bzw4scho/spack-src/VTK/ThirdParty/fmt/vtkfmt/vtkfmt/format.h:1732:11: error: cannot capture a bi
t-field by reference
336 if (sign) *it++ = static_cast<Char>(data::signs[sign]);
337 ^
Signed-off-by: Howard Pritchard <[email protected]>
Signed-off-by: Howard Pritchard <[email protected]>
* add psij package and deps * update hashes, URLs * linting * Update var/spack/repos/builtin/packages/py-psij-python/package.py Co-authored-by: Adam J. Stewart <[email protected]> * Update var/spack/repos/builtin/packages/py-pystache/package.py Co-authored-by: Adam J. Stewart <[email protected]> * Update var/spack/repos/builtin/packages/py-pystache/package.py Co-authored-by: Tamara Dahlgren <[email protected]> * Update package.py apply suggested change * Update package.py apply suggested change * Update package.py ensure maintainer inheritance * add psij to exaworks meta-package Co-authored-by: Adam J. Stewart <[email protected]> Co-authored-by: Tamara Dahlgren <[email protected]>
spackbot-app
bot
added
conflicts
core
Contributor
Author
|
Seems like I broke something by merging develop. I'll open a new PR. |
stephenmsachs
pushed a commit
to stephenmsachs/spack
that referenced
this pull request
Jan 3, 2023
Tagging @alalazo and @rschon2 The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs warning spack#2196: routine is both "inline" and "noinline" cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference. The issue does not appear with [email protected] or later: ``` $~: compiler=/shared/spack/opt/spack/linux-amzn2-x86_64_v3/gcc-12.2.0/intel-oneapi-compilers-2022.2.0-uqvb2553zy5toeapvoopacndd27x6p5m/compiler/2022.2.0/linux/bin/intel64/icpc $~: $compiler unique.c icpc: remark spack#10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message. ``` This is a clean version of spack#34167
alalazo
pushed a commit
that referenced
this pull request
Jan 5, 2023
The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs ``` warning #2196: routine is both "inline" and "noinline" ``` cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference. The issue does not appear with [email protected] or later: ``` $~: compiler=/shared/spack/opt/spack/linux-amzn2-x86_64_v3/gcc-12.2.0/intel-oneapi-compilers-2022.2.0-uqvb2553zy5toeapvoopacndd27x6p5m/compiler/2022.2.0/linux/bin/intel64/icpc $~: $compiler unique.c icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message. ``` This is a clean version of #34167 Co-authored-by: Stephen Sachs <[email protected]>
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 24, 2023
The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs ``` warning spack#2196: routine is both "inline" and "noinline" ``` cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference. The issue does not appear with [email protected] or later: ``` $~: compiler=/shared/spack/opt/spack/linux-amzn2-x86_64_v3/gcc-12.2.0/intel-oneapi-compilers-2022.2.0-uqvb2553zy5toeapvoopacndd27x6p5m/compiler/2022.2.0/linux/bin/intel64/icpc $~: $compiler unique.c icpc: remark spack#10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message. ``` This is a clean version of spack#34167 Co-authored-by: Stephen Sachs <[email protected]>
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs ``` warning spack#2196: routine is both "inline" and "noinline" ``` cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference. The issue does not appear with [email protected] or later: ``` $~: compiler=/shared/spack/opt/spack/linux-amzn2-x86_64_v3/gcc-12.2.0/intel-oneapi-compilers-2022.2.0-uqvb2553zy5toeapvoopacndd27x6p5m/compiler/2022.2.0/linux/bin/intel64/icpc $~: $compiler unique.c icpc: remark spack#10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message. ``` This is a clean version of spack#34167 Co-authored-by: Stephen Sachs <[email protected]>
techxdave
pushed a commit
to Tech-XCorp/spack
that referenced
this pull request
Feb 17, 2023
The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs ``` warning spack#2196: routine is both "inline" and "noinline" ``` cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference. The issue does not appear with [email protected] or later: ``` $~: compiler=/shared/spack/opt/spack/linux-amzn2-x86_64_v3/gcc-12.2.0/intel-oneapi-compilers-2022.2.0-uqvb2553zy5toeapvoopacndd27x6p5m/compiler/2022.2.0/linux/bin/intel64/icpc $~: $compiler unique.c icpc: remark spack#10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message. ``` This is a clean version of spack#34167 Co-authored-by: Stephen Sachs <[email protected]>
jmcarcell
pushed a commit
to key4hep/spack
that referenced
this pull request
Apr 13, 2023
The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs ``` warning spack#2196: routine is both "inline" and "noinline" ``` cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference. The issue does not appear with [email protected] or later: ``` $~: compiler=/shared/spack/opt/spack/linux-amzn2-x86_64_v3/gcc-12.2.0/intel-oneapi-compilers-2022.2.0-uqvb2553zy5toeapvoopacndd27x6p5m/compiler/2022.2.0/linux/bin/intel64/icpc $~: $compiler unique.c icpc: remark spack#10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message. ``` This is a clean version of spack#34167 Co-authored-by: Stephen Sachs <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs
warning #2196: routine is both "inline" and "noinline"
cmake bootstrap will fail due to the word 'warning'.
See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference.