root: new versions 6.26.08 and 6.26.10#34160
Conversation
spackbot-app
bot
requested review from
HadrienG2,
drbenmorgan,
greenc-FNAL and
vvolkl
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Confirmed both new sha256.
|
Will defer merge decision to give one or more maintainer a chance to comment. |
HadrienG2
left a comment
HadrienG2
left a comment
There was a problem hiding this comment.
While bugfixes may seem harmless, they do introduce support for newer dependency versions, and thus implicitly state that older versions are incompatible with older dependency versions.
This is something we care about in Spack, because people may want to build older ROOT releases on newer systems and it's better if we pick the right dependency versions by default without further intervention.
|
|
||
| # Production version | ||
| version("6.26.10", sha256="8e56bec397104017aa54f9eb554de7a1a134474fe0b3bb0f43a70fc4fabd625f") | ||
| version("6.26.08", sha256="4dda043e7918b40743ad0299ddd8d526b7078f0a3822fd06066df948af47940e") |
There was a problem hiding this comment.
If I understand the release notes correctly, you need 6.26.08+ to build with nlohmann_json 3.11+. The dependency on nlohmann_json should probably be updated accordingly.
There was a problem hiding this comment.
Similarly, clang 16 will have issues with older root : root-project/root#11128 .
| # Development version (when more recent than production). | ||
|
|
||
| # Production version | ||
| version("6.26.10", sha256="8e56bec397104017aa54f9eb554de7a1a134474fe0b3bb0f43a70fc4fabd625f") |
There was a problem hiding this comment.
Need at least this release for python 3.11+ : root-project/root#11713 .
There was a problem hiding this comment.
Similar for macOS 13 (though I'm not sure if we can set OS version requirements or conflicts in Spack) : root-project/root#11714
There was a problem hiding this comment.
I am wondering, though, whether from a community contribution workflow perspective it doesn't make sense to model these issues with upper limits on dependencies for older version. I.e. we could use depends_on("python@:3.10") until someone can verify that 3.11 works with a certain version. At that point they can add depends_on("python@:3.11") and modify depends_on("python@:3.10", when=":6.26.06").
Even though I currently don't have the time to figure out the dependencies (and test it, that's what takes most of the time), this still leaves the current package with the same issue: the most recent ROOT version is not working with the most recent python version (not the preferred version).
|
I'm going to close this PR and let someone else add the necessary version restrictions. I don't have the time until 2023 to dig through the ROOT PRs to address and test these version incompatibilities. |
3 participants
Bugfixes only, https://root.cern/doc/v626/release-notes.html#bugs-and-issues-fixed-in-this-release-4.